From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
David Miller <davem@davemloft.net>,
tony@bakeyournoodle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c
Date: Wed, 07 May 2008 15:49:07 +1000 [thread overview]
Message-ID: <1210139347.21644.239.camel@pasglop> (raw)
In-Reply-To: <18465.16592.41821.225568@cargo.ozlabs.ibm.com>
On Wed, 2008-05-07 at 15:40 +1000, Paul Mackerras wrote:
> > > (rationale: users tend to not read their dmesg much, but
> WARN_ON()'s do
> > > get noticed)
> >
> > OK by me, although if we're going to do much more of this it might
> be time
> > to add a WARN_ON which takes (fmt, args...).
>
> It would make a lot more sense to put the printk and/or WARN_ON inside
> sysfs_create_bin_file rather than in every single caller.
Amen !
Ben.
next prev parent reply other threads:[~2008-05-07 5:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 4:34 [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c Tony Breeds
2008-05-06 21:39 ` Andrew Morton
2008-05-06 21:43 ` David Miller
2008-05-06 21:56 ` Andrew Morton
2008-05-07 4:00 ` Arjan van de Ven
2008-05-07 4:12 ` Andrew Morton
2008-05-07 4:15 ` Arjan van de Ven
2008-05-07 4:20 ` Arjan van de Ven
2008-05-07 4:37 ` Benjamin Herrenschmidt
2008-05-07 4:23 ` Andrew Morton
2008-05-07 4:26 ` Andrew Morton
2008-05-07 4:41 ` Arjan van de Ven
2008-05-07 4:37 ` Arjan van de Ven
2008-05-07 5:40 ` Paul Mackerras
2008-05-07 5:49 ` Benjamin Herrenschmidt [this message]
2008-05-07 0:54 ` Benjamin Herrenschmidt
2008-05-07 1:20 ` Andrew Morton
2008-05-07 4:33 ` Benjamin Herrenschmidt
2008-05-07 8:23 ` Cornelia Huck
2008-05-07 21:43 ` Benjamin Herrenschmidt
2008-05-08 7:34 ` Cornelia Huck
2008-05-08 7:49 ` Benjamin Herrenschmidt
2008-05-08 8:36 ` Cornelia Huck
2008-05-08 22:03 ` Greg KH
2008-05-08 23:06 ` Benjamin Herrenschmidt
2008-05-08 23:50 ` Paul Mackerras
2008-05-09 0:02 ` Harvey Harrison
2008-05-09 5:32 ` Cornelia Huck
2008-05-09 5:33 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210139347.21644.239.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.