From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
tony@bakeyournoodle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c
Date: Thu, 08 May 2008 17:49:44 +1000 [thread overview]
Message-ID: <1210232984.1421.47.camel@pasglop> (raw)
In-Reply-To: <20080508093421.31cd735b@gondolin.boeblingen.de.ibm.com>
On Thu, 2008-05-08 at 09:34 +0200, Cornelia Huck wrote:
>
> I was under the impression that failing the initialization was usually
> the right thing to do, since we end up with an un-configurable,
> un-usable device. But that may be coloured by my experience with s390
> devices, where we rely on sysfs attributes extensively. If indeed most
> sysfs files are non-vital, removing the __must_check and relying on a
> scary warning in the core may be fine. (OTOH, adding checks to the
> core
> has helped us to find some lurking bugs.)
The driver can still fail initialization if it wants... I'm just
objecting to the __must_check.
Ben.
next prev parent reply other threads:[~2008-05-08 7:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 4:34 [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c Tony Breeds
2008-05-06 21:39 ` Andrew Morton
2008-05-06 21:43 ` David Miller
2008-05-06 21:56 ` Andrew Morton
2008-05-07 4:00 ` Arjan van de Ven
2008-05-07 4:12 ` Andrew Morton
2008-05-07 4:15 ` Arjan van de Ven
2008-05-07 4:20 ` Arjan van de Ven
2008-05-07 4:37 ` Benjamin Herrenschmidt
2008-05-07 4:23 ` Andrew Morton
2008-05-07 4:26 ` Andrew Morton
2008-05-07 4:41 ` Arjan van de Ven
2008-05-07 4:37 ` Arjan van de Ven
2008-05-07 5:40 ` Paul Mackerras
2008-05-07 5:49 ` Benjamin Herrenschmidt
2008-05-07 0:54 ` Benjamin Herrenschmidt
2008-05-07 1:20 ` Andrew Morton
2008-05-07 4:33 ` Benjamin Herrenschmidt
2008-05-07 8:23 ` Cornelia Huck
2008-05-07 21:43 ` Benjamin Herrenschmidt
2008-05-08 7:34 ` Cornelia Huck
2008-05-08 7:49 ` Benjamin Herrenschmidt [this message]
2008-05-08 8:36 ` Cornelia Huck
2008-05-08 22:03 ` Greg KH
2008-05-08 23:06 ` Benjamin Herrenschmidt
2008-05-08 23:50 ` Paul Mackerras
2008-05-09 0:02 ` Harvey Harrison
2008-05-09 5:32 ` Cornelia Huck
2008-05-09 5:33 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210232984.1421.47.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.