From: Dan Williams <dcbw@redhat.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: breed@users.sourceforge.net, linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wireless, airo: waitbusy() won't delay
Date: Tue, 13 May 2008 17:43:13 -0400 [thread overview]
Message-ID: <1210714993.987.3.camel@localhost.localdomain> (raw)
In-Reply-To: <4829F62B.8030003@gmail.com>
On Tue, 2008-05-13 at 22:12 +0200, Roel Kluin wrote:
> There will be no delay even when COMMAND_BUSY (defined 0x8000) is set:
> 0x8000 & (delay < 10000) will evaluate to 0 - when delay is 0.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Good catch.
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
> index 45f47c1..efb7444 100644
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
> @@ -2904,7 +2904,7 @@ EXPORT_SYMBOL(init_airo_card);
>
> static int waitbusy (struct airo_info *ai) {
> int delay = 0;
> - while ((IN4500 (ai, COMMAND) & COMMAND_BUSY) & (delay < 10000)) {
> + while ((IN4500 (ai, COMMAND) & COMMAND_BUSY) && (delay < 10000)) {
> udelay (10);
> if ((++delay % 20) == 0)
> OUT4500(ai, EVACK, EV_CLEARCOMMANDBUSY);
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-13 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 20:12 [PATCH] wireless, airo: waitbusy() won't delay Roel Kluin
2008-05-13 21:43 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210714993.987.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=breed@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.