From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub-probe gets a segfault
Date: Fri, 16 May 2008 14:02:40 -0400 [thread overview]
Message-ID: <1210960960.19414.6.camel@dv> (raw)
In-Reply-To: <3ac92b10805161048q6b4e12b4kd8cca66644d904a9@mail.gmail.com>
On Sat, 2008-05-17 at 13:18 +0000, Isaac Marcos wrote:
> The fix would be to reject RAID partitions in
> grub_lvm_scan_device().
> The only validity check in that function is presence of the
> LVM label in
> the first 4 sectors. Perhaps additional checks are needed.
> Good find Pavel. :-)
>
> Just a question, /dev/sda5 has an equivalent setup:
> # pvck /dev/sda5
> Device /dev/sda5 not found (or ignored by filtering).
> /dev/sda5 232 3396 25422831 fd Linux raid
> autodetect
>
> Why grub-probe doesn't fail on /dev/sda5?
I think because it has no LVM label. Maybe /dev/sda6 was holding a LVM
physical volume before, and the label was not erased when it became a
RAID partition.
As you can see, pvck doesn't display information partition. It means it
cannot be fooled by the label. And that's what GRUB should do.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-05-16 18:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 9:24 grub-probe gets a segfault Isaac M. Marcos
2008-05-08 15:55 ` Pavel Roskin
2008-05-08 16:23 ` Isaac M. Marcos
2008-05-08 22:15 ` Pavel Roskin
2008-05-09 13:02 ` Robert Millan
2008-05-09 16:43 ` Isaac M. Marcos
2008-05-09 20:56 ` Pavel Roskin
2008-05-12 13:44 ` Isaac M. Marcos
2008-05-15 22:45 ` Pavel Roskin
2008-05-16 17:48 ` Isaac Marcos
2008-05-16 18:02 ` Pavel Roskin [this message]
2008-05-22 0:50 ` Isaac M. Marcos
2008-05-22 1:06 ` Pavel Roskin
2008-05-22 10:52 ` Pavel Roskin
2008-05-24 0:10 ` Isaac M. Marcos
2008-05-27 20:26 ` Pavel Roskin
2008-05-28 13:36 ` Robert Millan
2008-05-28 18:28 ` Isaac M. Marcos
2008-05-30 3:59 ` Pavel Roskin
2008-05-12 14:16 ` Isaac M. Marcos
2008-05-20 16:37 ` Jeff Chua
2008-05-20 19:53 ` Pavel Roskin
2008-05-21 2:22 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210960960.19414.6.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.