linux/a.out.h is not exported to userspace

linux/a.out.h is not exported to userspace

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Hi,

Looking for a compile failure for a package on uclibc system using
kernel-headers from 2.6.25 I found that linux/a.out.h is no more
exported to userland anymore.

This commit below has disabled it from being exported. The commit Do not
export asm/page.h during make headers_install so I was wondering if it
was intended to unexport linux/a.out.h or not.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ed7b1889da256977574663689b598d88950bbd23


Looking at the patch from lkml post

http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html

second hunk to include/linux/Kbuild was not applied which caused this
problem.

I think I do not fall into Signed-off-by definition. I tested the
following patch on 2.6.25.

Thanks

-Khem

Tested-by: Khem Raj <raj.khem@gmail.com>

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b7d81b2..8a3d93e 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -168,6 +168,7 @@ unifdef-y += acct.h
 unifdef-y += adb.h
 unifdef-y += adfs_fs.h
 unifdef-y += agpgart.h
+unifdef-y += a.out.h
 unifdef-y += apm_bios.h
 unifdef-y += atalk.h
 unifdef-y += atmdev.h


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: linux/a.out.h is not exported to userspace

[Stefan Hellermann]

> Hi,
> 
> Looking for a compile failure for a package on uclibc system using
> kernel-headers from 2.6.25 I found that linux/a.out.h is no more
> exported to userland anymore.
> 
> This commit below has disabled it from being exported. The commit Do not
> export asm/page.h during make headers_install so I was wondering if it
> was intended to unexport linux/a.out.h or not.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ed7b1889da256977574663689b598d88950bbd23
> 
> 
> Looking at the patch from lkml post
> 
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
> 
> second hunk to include/linux/Kbuild was not applied which caused this
> problem.
> 

I saw this problem, too. The patch fixes this.

> I think I do not fall into Signed-off-by definition. I tested the
> following patch on 2.6.25.
> 
> Thanks
> 
> -Khem
> 
> Tested-by: Khem Raj <raj.khem@gmail.com>

Tested-by: Stefan Hellermann

> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b7d81b2..8a3d93e 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -168,6 +168,7 @@ unifdef-y += acct.h
>  unifdef-y += adb.h
>  unifdef-y += adfs_fs.h
>  unifdef-y += agpgart.h
> +unifdef-y += a.out.h
>  unifdef-y += apm_bios.h
>  unifdef-y += atalk.h
>  unifdef-y += atmdev.h
> 

Re: linux/a.out.h is not exported to userspace

[Pekka Enberg]

(adding cc)

On Sat, May 17, 2008 at 3:13 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Looking for a compile failure for a package on uclibc system using
> kernel-headers from 2.6.25 I found that linux/a.out.h is no more
> exported to userland anymore.
>
> This commit below has disabled it from being exported. The commit Do not
> export asm/page.h during make headers_install so I was wondering if it
> was intended to unexport linux/a.out.h or not.
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ed7b1889da256977574663689b598d88950bbd23
>
> Looking at the patch from lkml post
>
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
>
> second hunk to include/linux/Kbuild was not applied which caused this
> problem.
>
> I think I do not fall into Signed-off-by definition. I tested the
> following patch on 2.6.25.
>
> Thanks
>
> -Khem
>
> Tested-by: Khem Raj <raj.khem@gmail.com>
>
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b7d81b2..8a3d93e 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -168,6 +168,7 @@ unifdef-y += acct.h
>  unifdef-y += adb.h
>  unifdef-y += adfs_fs.h
>  unifdef-y += agpgart.h
> +unifdef-y += a.out.h
>  unifdef-y += apm_bios.h
>  unifdef-y += atalk.h
>  unifdef-y += atmdev.h

It's usually a good idea to cc the patch author(s) if you want
something fixed....

Re: linux/a.out.h is not exported to userspace

[David Woodhouse]

On Fri, 2008-05-16 at 17:13 -0700, Khem Raj wrote:
> Hi,
> 
> Looking for a compile failure for a package on uclibc system using
> kernel-headers from 2.6.25 I found that linux/a.out.h is no more
> exported to userland anymore.
> 
> This commit below has disabled it from being exported. The commit Do not
> export asm/page.h during make headers_install so I was wondering if it
> was intended to unexport linux/a.out.h or not.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ed7b1889da256977574663689b598d88950bbd23
> 
> 
> Looking at the patch from lkml post
> 
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
> 
> second hunk to include/linux/Kbuild was not applied which caused this
> problem.
> 
> I think I do not fall into Signed-off-by definition. I tested the
> following patch on 2.6.25.
> 
> Thanks
> 
> -Khem
> 
> Tested-by: Khem Raj <raj.khem@gmail.com>
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b7d81b2..8a3d93e 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -168,6 +168,7 @@ unifdef-y += acct.h
>  unifdef-y += adb.h
>  unifdef-y += adfs_fs.h
>  unifdef-y += agpgart.h
> +unifdef-y += a.out.h
>  unifdef-y += apm_bios.h
>  unifdef-y += atalk.h
>  unifdef-y += atmdev.h

That'll export <linux/a.out.h> even on architectures where <asm/a.out.h>
doesn't exist -- which will cause headers_check to fail.

Perhaps we could do it something like this:
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -168,6 +168,9 @@ unifdef-y += acct.h
 unifdef-y += adb.h
 unifdef-y += adfs_fs.h
 unifdef-y += agpgart.h
+ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
+unifdef-y += a.out.h
+endif
 unifdef-y += apm_bios.h
 unifdef-y += atalk.h
 unifdef-y += atmdev.h

In fact, perhaps we could do <linux/kvm.h> that way too -- I believe I
objected to using a CONFIG symbol, but the mere existence of the file
would be fine. I don't think we thought of that at the time.

-- 
dwmw2

Re: linux/a.out.h is not exported to userspace

[Andrew Morton]

On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <raj.khem@gmail.com> wrote:

> Hi,
> 
> Looking for a compile failure for a package on uclibc system using
> kernel-headers from 2.6.25 I found that linux/a.out.h is no more
> exported to userland anymore.
> 
> This commit below has disabled it from being exported. The commit Do not
> export asm/page.h during make headers_install so I was wondering if it
> was intended to unexport linux/a.out.h or not.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ed7b1889da256977574663689b598d88950bbd23
> 
> 
> Looking at the patch from lkml post
> 
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
> 
> second hunk to include/linux/Kbuild was not applied which caused this
> problem.
> 
> I think I do not fall into Signed-off-by definition. I tested the
> following patch on 2.6.25.
> 
> Thanks
> 
> -Khem
> 
> Tested-by: Khem Raj <raj.khem@gmail.com>
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index b7d81b2..8a3d93e 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -168,6 +168,7 @@ unifdef-y += acct.h
>  unifdef-y += adb.h
>  unifdef-y += adfs_fs.h
>  unifdef-y += agpgart.h
> +unifdef-y += a.out.h
>  unifdef-y += apm_bios.h
>  unifdef-y += atalk.h
>  unifdef-y += atmdev.h

This breaks `make headerscheck' on s390:

/usr/src/devel/usr/include/linux/a.out.h requires asm/a.out.h, which does not exist in exported headers

which might be an s390 problem.

Re: linux/a.out.h is not exported to userspace

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Fri, 2008-05-23 at 00:32 -0700, Andrew Morton wrote:

> 
> This breaks `make headerscheck' on s390:
> 
> /usr/src/devel/usr/include/linux/a.out.h requires asm/a.out.h, which does not exist in exported headers
> 
> which might be an s390 problem.

There was also this patch that David proposed here

http://lkml.org/lkml/2008/5/18/46

this patch also takes care of the architectures that do not have
asm/a.out.h. I tried this patch on s390 and arm one with and one without
asm/a.out.h

Thanks

-Khem



diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 93b9885..b6fbb25 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -166,6 +166,9 @@ unifdef-y += acct.h
 unifdef-y += adb.h
 unifdef-y += adfs_fs.h
 unifdef-y += agpgart.h
+ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
+unifdef-y += a.out.h
+endif
 unifdef-y += apm_bios.h
 unifdef-y += atalk.h
 unifdef-y += atmdev.h


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: linux/a.out.h is not exported to userspace

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On Fri, 2008-05-23 at 00:32 -0700, Andrew Morton wrote:
> On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <raj.khem@gmail.com> wrote:

> 
> This breaks `make headerscheck' on s390:
> 
> /usr/src/devel/usr/include/linux/a.out.h requires asm/a.out.h, which does not exist in exported headers
> 
> which might be an s390 problem.

The attached patch from David is a replacement patch. I have tested this
patch by running make headers_install on every architecture under arch/
It works for all (except 'um' and 'ppc' which do not export headers)

Thanks

-Khem


Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 93b9885..b6fbb25 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -166,6 +166,9 @@ unifdef-y += acct.h
 unifdef-y += adb.h
 unifdef-y += adfs_fs.h
 unifdef-y += agpgart.h
+ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
+unifdef-y += a.out.h
+endif
 unifdef-y += apm_bios.h
 unifdef-y += atalk.h
 unifdef-y += atmdev.h


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: linux/a.out.h is not exported to userspace

[David Woodhouse]

On Thu, 2008-05-29 at 21:35 -0700, Khem Raj wrote:
> On Fri, 2008-05-23 at 00:32 -0700, Andrew Morton wrote:
> > On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <raj.khem@gmail.com> wrote:
> 
> > 
> > This breaks `make headerscheck' on s390:
> > 
> > /usr/src/devel/usr/include/linux/a.out.h requires asm/a.out.h, which does not exist in exported headers
> > 
> > which might be an s390 problem.
> 
> The attached patch from David is a replacement patch. I have tested this
> patch by running make headers_install on every architecture under arch/
> It works for all (except 'um' and 'ppc' which do not export headers)

We also need to remove the instance of #ifdef CONFIG_something which
David sneaked in to <linux/a.out.h>.

And make a 'headers_check' test for it :)

-- 
dwmw2