From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, agl@us.ibm.com,
wli@holomorphy.com, kenchen@google.com, dwg@au1.ibm.com,
andi@firstfloor.org, Mel Gorman <mel@csn.ul.ie>,
dean@arctic.org, abh@cray.com, Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH 2/2] huge page MAP_NORESERVE review cleanups
Date: Fri, 30 May 2008 17:58:39 +0100 [thread overview]
Message-ID: <1212166719.0@pinky> (raw)
In-Reply-To: exportbomb.1212166524@pinky
Use the new encapsulated huge page offset helper.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
mm/hugetlb.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 1dce03a..901e580 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -733,8 +733,7 @@ static int vma_needs_reservation(struct vm_area_struct *vma, unsigned long addr)
struct inode *inode = mapping->host;
if (vma->vm_flags & VM_SHARED) {
- unsigned long idx = ((addr - vma->vm_start) >> HPAGE_SHIFT) +
- (vma->vm_pgoff >> (HPAGE_SHIFT - PAGE_SHIFT));
+ pgoff_t idx = vma_pagecache_offset(vma, addr);
return region_chg(&inode->i_mapping->private_list,
idx, idx + 1);
@@ -752,8 +751,7 @@ static void vma_commit_reservation(struct vm_area_struct *vma,
struct inode *inode = mapping->host;
if (vma->vm_flags & VM_SHARED) {
- unsigned long idx = ((addr - vma->vm_start) >> HPAGE_SHIFT) +
- (vma->vm_pgoff >> (HPAGE_SHIFT - PAGE_SHIFT));
+ pgoff_t idx = vma_pagecache_offset(vma, addr);
region_add(&inode->i_mapping->private_list, idx, idx + 1);
}
}
WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, agl@us.ibm.com,
wli@holomorphy.com, kenchen@google.com, dwg@au1.ibm.com,
andi@firstfloor.org, Mel Gorman <mel@csn.ul.ie>,
dean@arctic.org, abh@cray.com, Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH 2/2] huge page MAP_NORESERVE review cleanups
Date: Fri, 30 May 2008 17:58:39 +0100 [thread overview]
Message-ID: <1212166719.0@pinky> (raw)
In-Reply-To: exportbomb.1212166524@pinky
Use the new encapsulated huge page offset helper.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
mm/hugetlb.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 1dce03a..901e580 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -733,8 +733,7 @@ static int vma_needs_reservation(struct vm_area_struct *vma, unsigned long addr)
struct inode *inode = mapping->host;
if (vma->vm_flags & VM_SHARED) {
- unsigned long idx = ((addr - vma->vm_start) >> HPAGE_SHIFT) +
- (vma->vm_pgoff >> (HPAGE_SHIFT - PAGE_SHIFT));
+ pgoff_t idx = vma_pagecache_offset(vma, addr);
return region_chg(&inode->i_mapping->private_list,
idx, idx + 1);
@@ -752,8 +751,7 @@ static void vma_commit_reservation(struct vm_area_struct *vma,
struct inode *inode = mapping->host;
if (vma->vm_flags & VM_SHARED) {
- unsigned long idx = ((addr - vma->vm_start) >> HPAGE_SHIFT) +
- (vma->vm_pgoff >> (HPAGE_SHIFT - PAGE_SHIFT));
+ pgoff_t idx = vma_pagecache_offset(vma, addr);
region_add(&inode->i_mapping->private_list, idx, idx + 1);
}
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-30 16:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 18:50 [PATCH 0/3] Guarantee faults for processes that call mmap(MAP_PRIVATE) on hugetlbfs v4 Mel Gorman
2008-05-27 18:50 ` Mel Gorman
2008-05-27 18:50 ` [PATCH 1/3] Move hugetlb_acct_memory() Mel Gorman
2008-05-27 18:50 ` Mel Gorman
2008-05-28 13:37 ` Adam Litke
2008-05-28 13:37 ` Adam Litke
2008-05-27 18:51 ` [PATCH 2/3] Reserve huge pages for reliable MAP_PRIVATE hugetlbfs mappings until fork() Mel Gorman
2008-05-27 18:51 ` Mel Gorman
2008-05-28 13:52 ` Adam Litke
2008-05-28 13:52 ` Adam Litke
2008-05-27 18:51 ` [PATCH 3/3] Guarantee that COW faults for a process that called mmap(MAP_PRIVATE) on hugetlbfs will succeed Mel Gorman
2008-05-27 18:51 ` Mel Gorman
2008-05-28 16:00 ` Mel Gorman
2008-05-28 16:00 ` Mel Gorman
2008-05-28 18:15 ` Adam Litke
2008-05-28 18:15 ` Adam Litke
2008-05-28 18:16 ` Adam Litke
2008-05-28 18:16 ` Adam Litke
2008-05-29 1:42 ` Andrew Morton
2008-05-29 1:42 ` Andrew Morton
2008-05-30 16:57 ` [PATCH 0/2] hugetlb reservations v4/MAP_NORESERVE V3 cleanups Andy Whitcroft
2008-05-30 16:57 ` Andy Whitcroft
2008-05-30 16:58 ` [PATCH 1/2] huge page private reservation review cleanups Andy Whitcroft
2008-05-30 16:58 ` Andy Whitcroft
2008-05-30 20:29 ` Andrew Morton
2008-05-30 20:29 ` Andrew Morton
2008-05-31 13:06 ` Mel Gorman
2008-05-31 13:06 ` Mel Gorman
2008-05-31 12:21 ` Mel Gorman
2008-05-31 12:21 ` Mel Gorman
2008-05-30 16:58 ` Andy Whitcroft [this message]
2008-05-30 16:58 ` [PATCH 2/2] huge page MAP_NORESERVE " Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212166719.0@pinky \
--to=apw@shadowen.org \
--cc=abh@cray.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dean@arctic.org \
--cc=dwg@au1.ibm.com \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.