All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state
@ 2021-12-25 10:06 ` s921975628
  0 siblings, 0 replies; 4+ messages in thread
From: s921975628 @ 2021-12-25 10:06 UTC (permalink / raw)
  To: richard, vigneshr, miquel.raynal; +Cc: linux-mtd, linux-kernel, RinHizakura

From: RinHizakura <s921975628@gmail.com>

The moving block of codes is shared between both 'if' and 'else' condition,
we can move it out to reduce the duplication.

Signed-off-by: RinHizakura <s921975628@gmail.com>
---
 drivers/mtd/nand/raw/nandsim.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c
index 3698fb430..2ef6bddf0 100644
--- a/drivers/mtd/nand/raw/nandsim.c
+++ b/drivers/mtd/nand/raw/nandsim.c
@@ -1731,14 +1731,6 @@ static void ns_switch_state(struct nandsim *ns)
 			"state: %s, nxstate: %s\n",
 		       ns_get_state_name(ns->state),
 		       ns_get_state_name(ns->nxstate));
-
-		/* See, whether we need to do some action */
-		if ((ns->state & ACTION_MASK) &&
-		    ns_do_state_action(ns, ns->state) < 0) {
-			ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
-			return;
-		}
-
 	} else {
 		/*
 		 * We don't yet know which operation we perform.
@@ -1755,12 +1747,13 @@ static void ns_switch_state(struct nandsim *ns)
 
 		if (ns_find_operation(ns, 0))
 			return;
+	}
 
-		if ((ns->state & ACTION_MASK) &&
-		    ns_do_state_action(ns, ns->state) < 0) {
-			ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
-			return;
-		}
+	/* See, whether we need to do some action */
+	if ((ns->state & ACTION_MASK) &&
+	    ns_do_state_action(ns, ns->state) < 0) {
+		ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
+		return;
 	}
 
 	/* For 16x devices column means the page offset in words */
-- 
2.25.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state
@ 2021-12-25 10:06 ` s921975628
  0 siblings, 0 replies; 4+ messages in thread
From: s921975628 @ 2021-12-25 10:06 UTC (permalink / raw)
  To: richard, vigneshr, miquel.raynal; +Cc: linux-mtd, linux-kernel, RinHizakura

From: RinHizakura <s921975628@gmail.com>

The moving block of codes is shared between both 'if' and 'else' condition,
we can move it out to reduce the duplication.

Signed-off-by: RinHizakura <s921975628@gmail.com>
---
 drivers/mtd/nand/raw/nandsim.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c
index 3698fb430..2ef6bddf0 100644
--- a/drivers/mtd/nand/raw/nandsim.c
+++ b/drivers/mtd/nand/raw/nandsim.c
@@ -1731,14 +1731,6 @@ static void ns_switch_state(struct nandsim *ns)
 			"state: %s, nxstate: %s\n",
 		       ns_get_state_name(ns->state),
 		       ns_get_state_name(ns->nxstate));
-
-		/* See, whether we need to do some action */
-		if ((ns->state & ACTION_MASK) &&
-		    ns_do_state_action(ns, ns->state) < 0) {
-			ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
-			return;
-		}
-
 	} else {
 		/*
 		 * We don't yet know which operation we perform.
@@ -1755,12 +1747,13 @@ static void ns_switch_state(struct nandsim *ns)
 
 		if (ns_find_operation(ns, 0))
 			return;
+	}
 
-		if ((ns->state & ACTION_MASK) &&
-		    ns_do_state_action(ns, ns->state) < 0) {
-			ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
-			return;
-		}
+	/* See, whether we need to do some action */
+	if ((ns->state & ACTION_MASK) &&
+	    ns_do_state_action(ns, ns->state) < 0) {
+		ns_switch_to_ready_state(ns, NS_STATUS_FAILED(ns));
+		return;
 	}
 
 	/* For 16x devices column means the page offset in words */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state
  2021-12-25 10:06 ` s921975628
@ 2021-12-25 21:10   ` Richard Weinberger
  -1 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2021-12-25 21:10 UTC (permalink / raw)
  To: s921975628; +Cc: Vignesh Raghavendra, Miquel Raynal, linux-mtd, linux-kernel

----- Ursprüngliche Mail -----
> Von: s921975628@gmail.com
> An: "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "RinHizakura"
> <s921975628@gmail.com>
> Gesendet: Samstag, 25. Dezember 2021 11:06:48
> Betreff: [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state

> From: RinHizakura <s921975628@gmail.com>
> 
> The moving block of codes is shared between both 'if' and 'else' condition,
> we can move it out to reduce the duplication.
> 
> Signed-off-by: RinHizakura <s921975628@gmail.com>
> ---
> drivers/mtd/nand/raw/nandsim.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state
@ 2021-12-25 21:10   ` Richard Weinberger
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2021-12-25 21:10 UTC (permalink / raw)
  To: s921975628; +Cc: Vignesh Raghavendra, Miquel Raynal, linux-mtd, linux-kernel

----- Ursprüngliche Mail -----
> Von: s921975628@gmail.com
> An: "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "RinHizakura"
> <s921975628@gmail.com>
> Gesendet: Samstag, 25. Dezember 2021 11:06:48
> Betreff: [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state

> From: RinHizakura <s921975628@gmail.com>
> 
> The moving block of codes is shared between both 'if' and 'else' condition,
> we can move it out to reduce the duplication.
> 
> Signed-off-by: RinHizakura <s921975628@gmail.com>
> ---
> drivers/mtd/nand/raw/nandsim.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-25 21:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-25 10:06 [PATCH 2/3] mtd: rawnand: nandsim: Merge repeat codes in ns_switch_state s921975628
2021-12-25 10:06 ` s921975628
2021-12-25 21:10 ` Richard Weinberger
2021-12-25 21:10   ` Richard Weinberger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.