Re: [PATCH] biosdisk / open_device() messing up offsets

[Pavel Roskin <proski@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]

On Sun, 2008-06-08 at 19:49 +0800, Bean wrote:

> Can you use grub-fstest ?
> 
> Also, the header is from
> 
> +  grub_printf ("header: %d %d %d\n", log->first_block,
> log->last_block, log->start_block);
> 
> I don't know why the number doesn't show, unless log is invalid
> pointer. Perhaps the size is invalid, try to add a debug line to show
> the allocated size of log:
> 
>   log = grub_malloc (sizeof (struct grub_fshelp_journal) +
>                      grub_be_to_cpu32 (jsb->maxlen) * sizeof
> (grub_disk_addr_t));

The debug output must be getting split somewhere.  If I replace colons
and spaces with underscores, I get some numbers.  Anyway, the
installation with the patch is unnecessary.

I made a short partition and installed grub on it, but there are no
problems with it in qemu.

But I can reproduce the problem with grub-fstest on the root partition.

[root@dv grub2]# grub-fstest /dev/sda1 ls /    
lost+found/ bin/ boot/ data/ dev/ etc/ home/ lib/ lib64/ media/ mnt/
opt/ proc/ root/ sbin/ scratchbox/ selinux/ srv/ sys/ tftpboot/ tmp/
usr/ var/ debug/ tftpboot;4834754b 
[root@dv grub2]# grub-fstest /dev/sda1 ls /boot

[root@dv grub2]# ls /   
bin   debug  home   lost+found  opt   sbin        srv
tftpboot;4834754b  var
boot  dev    lib    media       proc  scratchbox  sys       tmp
data  etc    lib64  mnt         root  selinux     tftpboot  usr
[root@dv grub2]# ls /boot
System.map                    grub                      vmlinuz
System.map-2.6.26-rc4-wl      initrd-2.6.26-rc4-wl.img
vmlinuz-2.6.26-rc4-wl
System.map-2.6.26-rc4-wl.old  memtest86+-2.01
vmlinuz-2.6.26-rc4-wl.old
[root@dv grub2]#

As you can see, "grub-fstest /dev/sda1 ls /boot" fails to find any
files.  Then I patched grub with your patch.  The output of the same
command is attached (compressed).

-- 
Regards,
Pavel Roskin

[-- Attachment #2: Log-boot.bz2 --]
[-- Type: application/x-bzip, Size: 14355 bytes --]