From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] biosdisk / open_device() messing up offsets
Date: Thu, 12 Jun 2008 12:25:18 -0400 [thread overview]
Message-ID: <1213287918.20094.4.camel@dv> (raw)
In-Reply-To: <ca0f59980806120251m7d3ef9cbq8c073079c983718f@mail.gmail.com>
On Thu, 2008-06-12 at 17:51 +0800, Bean wrote:
> The call in grub_ext2_read_inode should be ok, blkoff would limit the
> read access to within a block.
You are right. Now that we have grub_fshelp_read(), we don't need that
code, so I'm removing it. The block normalization should be done in one
place.
> Seems fine to me.
Committed.
> grub_ext3_get_journal still have some issue, but I
> can fix it after you commit it.
Please go ahead. And please take care of reiserfs if you can.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-06-12 16:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 23:35 [PATCH] biosdisk / open_device() messing up offsets Robert Millan
2008-06-05 1:47 ` Pavel Roskin
2008-06-05 21:12 ` Robert Millan
2008-06-06 15:56 ` Robert Millan
2008-06-06 22:53 ` Pavel Roskin
2008-06-06 23:38 ` Robert Millan
2008-06-07 2:58 ` Pavel Roskin
2008-06-08 19:29 ` Robert Millan
2008-06-07 6:33 ` Pavel Roskin
2008-06-07 7:48 ` Bean
2008-06-08 6:00 ` Pavel Roskin
2008-06-08 6:44 ` Bean
2008-06-08 6:52 ` Pavel Roskin
2008-06-08 7:11 ` Bean
2008-06-08 7:29 ` Pavel Roskin
2008-06-08 11:49 ` Bean
2008-06-08 18:42 ` Pavel Roskin
2008-06-08 18:57 ` Bean
2008-06-09 1:43 ` Pavel Roskin
2008-06-09 18:30 ` Bean
2008-06-10 7:16 ` Bean
2008-06-10 18:26 ` Pavel Roskin
2008-06-10 18:51 ` Bean
2008-06-10 20:19 ` Pavel Roskin
2008-06-10 22:58 ` Pavel Roskin
2008-06-10 23:18 ` [RFC PATCH] " Pavel Roskin
2008-06-11 5:25 ` Bean
2008-06-12 4:01 ` Pavel Roskin
2008-06-12 6:22 ` Pavel Roskin
2008-06-12 9:51 ` Bean
2008-06-12 16:25 ` Pavel Roskin [this message]
2008-06-13 3:48 ` Bean
2008-06-13 4:31 ` Pavel Roskin
2008-06-13 4:39 ` Bean
2008-06-13 5:00 ` Pavel Roskin
2008-06-13 5:18 ` Bean
2008-06-07 8:37 ` Bean
2008-06-08 5:41 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213287918.20094.4.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.