From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/char/tape_3590.c: introduce missing
Date: Mon, 09 Jun 2008 08:35:52 +0000 [thread overview]
Message-ID: <1213000552.19343.15.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0806081456260.10294@ask.diku.dk>
On Sun, 2008-06-08 at 14:56 +0200, Julia Lawall wrote:
> diff -u -p a/drivers/s390/char/tape_3590.c
> b/drivers/s390/char/tape_3590.c
> --- a/drivers/s390/char/tape_3590.c
> +++ b/drivers/s390/char/tape_3590.c
> @@ -1598,7 +1598,7 @@ tape_3590_setup_device(struct tape_devic
> rc = tape_3590_read_dev_chars(device, rdc_data);
> if (rc) {
> DBF_LH(3, "Read device characteristics failed!\n");
> - goto fail_kmalloc;
> + goto fail_rdc_data;
> }
> rc = tape_std_assign(device);
> if (rc)
>
Nice catch! I'll add this to the git390 queue for 2.6.26.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/char/tape_3590.c: introduce missing kfree
Date: Mon, 09 Jun 2008 10:35:52 +0200 [thread overview]
Message-ID: <1213000552.19343.15.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0806081456260.10294@ask.diku.dk>
On Sun, 2008-06-08 at 14:56 +0200, Julia Lawall wrote:
> diff -u -p a/drivers/s390/char/tape_3590.c
> b/drivers/s390/char/tape_3590.c
> --- a/drivers/s390/char/tape_3590.c
> +++ b/drivers/s390/char/tape_3590.c
> @@ -1598,7 +1598,7 @@ tape_3590_setup_device(struct tape_devic
> rc = tape_3590_read_dev_chars(device, rdc_data);
> if (rc) {
> DBF_LH(3, "Read device characteristics failed!\n");
> - goto fail_kmalloc;
> + goto fail_rdc_data;
> }
> rc = tape_std_assign(device);
> if (rc)
>
Nice catch! I'll add this to the git390 queue for 2.6.26.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-06-09 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 12:56 [PATCH 1/2] drivers/s390/char/tape_3590.c: introduce missing kfree Julia Lawall
2008-06-08 12:56 ` Julia Lawall
2008-06-09 8:35 ` Martin Schwidefsky [this message]
2008-06-09 8:35 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213000552.19343.15.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.