From: Hollis Blanchard <hollisb@us.ibm.com>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC
Date: Mon, 09 Jun 2008 14:54:42 +0000 [thread overview]
Message-ID: <1213023282.3358.2.camel@localhost.localdomain> (raw)
In-Reply-To: <600753fabc8b38e54129.1213021421@thinkpadL>
On Mon, 2008-06-09 at 09:23 -0500, Jerone Young wrote:
> diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c
> --- a/qemu/gdbstub.c
> +++ b/qemu/gdbstub.c
> @@ -983,6 +983,7 @@ static int gdb_handle_packet(GDBState *s
> kvm_load_registers(env);
> #elif defined (TARGET_PPC)
> env->nip = addr;
> + kvm_load_registers(env);
> #elif defined (TARGET_SPARC)
> env->pc = addr;
> env->npc = addr + 4;
> @@ -1021,6 +1022,7 @@ static int gdb_handle_packet(GDBState *s
> kvm_load_registers(env);
> #elif defined (TARGET_PPC)
> env->nip = addr;
> + kvm_load_registers(env);
> #elif defined (TARGET_SPARC)
> env->pc = addr;
> env->npc = addr + 4;
These should be protected by a kvm_enabled() test, just like you see for
x86 four lines earlier.
--
Hollis Blanchard
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb@us.ibm.com>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC
Date: Mon, 09 Jun 2008 09:54:42 -0500 [thread overview]
Message-ID: <1213023282.3358.2.camel@localhost.localdomain> (raw)
In-Reply-To: <600753fabc8b38e54129.1213021421@thinkpadL>
On Mon, 2008-06-09 at 09:23 -0500, Jerone Young wrote:
> diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c
> --- a/qemu/gdbstub.c
> +++ b/qemu/gdbstub.c
> @@ -983,6 +983,7 @@ static int gdb_handle_packet(GDBState *s
> kvm_load_registers(env);
> #elif defined (TARGET_PPC)
> env->nip = addr;
> + kvm_load_registers(env);
> #elif defined (TARGET_SPARC)
> env->pc = addr;
> env->npc = addr + 4;
> @@ -1021,6 +1022,7 @@ static int gdb_handle_packet(GDBState *s
> kvm_load_registers(env);
> #elif defined (TARGET_PPC)
> env->nip = addr;
> + kvm_load_registers(env);
> #elif defined (TARGET_SPARC)
> env->pc = addr;
> env->npc = addr + 4;
These should be protected by a kvm_enabled() test, just like you see for
x86 four lines earlier.
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-06-09 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 14:23 [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC Jerone Young
2008-06-09 14:23 ` Jerone Young
2008-06-09 14:54 ` Hollis Blanchard [this message]
2008-06-09 14:54 ` Hollis Blanchard
2008-06-09 15:06 ` Jerone Young
2008-06-09 15:06 ` Jerone Young
2008-06-18 13:39 ` Avi Kivity
2008-06-18 13:39 ` Avi Kivity
2008-06-18 13:39 ` Avi Kivity
2008-06-18 13:39 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213023282.3358.2.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=jyoung5@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.