All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
	linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net
Subject: Re: [ipw3945-devel] [BUG] iwlwifi 3945 works only with disable_hw_scan=1
Date: Fri, 13 Jun 2008 10:00:39 +0800	[thread overview]
Message-ID: <1213322439.7814.770.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1213282970.6589.9.camel@localhost.localdomain>

On Thu, 2008-06-12 at 11:02 -0400, Dan Williams wrote:
> > I guess that the right solution is to listen to the wireless button
> (via 
> > input layer), and turn card on manually.
> > 
> > If I remember correctly there is something like that in kernel, I
> try to 
> > enable this.
> > 
> > Otherwise this can be implemented in userspace.
> 
> The right solution is for NM to not take the device down (essentially
> doing SIOCSIFFLAGS with !IFF_UP), but to set the TX power off.
> However,
> that's not possible right now, because HAL doesn't provide enough
> information about the killswitches to distinguish between a software
> rfkill (which means we can turn the power back on) and a hardware
> rfkill
> (which means the user has to flip something).  On ipw2100, 2200, and
> 2915, setting the TX power off looks exactly like a hardware kill to
> HAL, so if you chose unchecked "Enable Wireless" in the nm applet,
> you'd never be able to turn wireless back on, because HAL and NM think
> there's a hardware kill active.

I think who takes the interface down is responsible to bring it up. Even
if the driver receives a rf_kill switch disabled interrupt, it should
keep the current IFF_UP status. It should never bring it up or down
itself. (Think about the carrier on/off in ethernet).

I wonder why NM need to ifdown or "txpower off" when rf_kill switch
(both for SW and HW) is enabled. The driver already handles it. Could it
save more power?

Thanks,
-yi


  reply	other threads:[~2008-06-13  2:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 15:47 [BUG] iwlwifi 3945 works only with disable_hw_scan=1 Maxim Levitsky
2008-06-12  2:26 ` [ipw3945-devel] " Zhu Yi
2008-06-12  6:42   ` drago01
2008-06-12  7:08     ` Zhu Yi
2008-06-12 12:48   ` Maxim Levitsky
2008-06-12 14:22     ` Maxim Levitsky
2008-06-12 14:26       ` Norbert Preining
2008-06-12 15:02     ` Dan Williams
2008-06-13  2:00       ` Zhu Yi [this message]
2008-06-13 14:45         ` Dan Williams
2008-06-16  1:40           ` Zhu Yi
  -- strict thread matches above, loose matches on Subject: below --
2008-06-11 15:07 Maxim Levitsky
2008-06-12  3:28 ` Zhu Yi
2008-06-12 13:59   ` [ipw3945-devel] " John W. Linville
2008-06-12 14:19     ` Maxim Levitsky
2008-06-12 20:25     ` Stephen Clark
2008-06-13  7:35     ` Zhu Yi
2008-06-13  8:48       ` Filippo Zangheri
2008-06-13 12:37         ` Tor Håkon Haugen
2008-06-13 13:03       ` John W. Linville
2008-06-13 14:59         ` Tor Håkon Haugen
2008-06-13 15:06           ` Maxim Levitsky
2008-06-13 15:09             ` Tor Håkon Haugen
2008-06-13 20:04             ` Tomas Winkler
2008-06-14 10:00               ` Maxim Levitsky
2008-06-14 16:50               ` Luis R. Rodriguez
2008-06-15 13:42               ` Maxim Levitsky
2008-06-15 13:47                 ` Tomas Winkler
2008-06-15 14:12                   ` Maxim Levitsky
2008-06-15 15:09                     ` Tomas Winkler
2008-06-15 16:47                       ` Tomas Winkler
2008-06-16  5:50                         ` Maxim Levitsky
2008-06-16  5:52                           ` Tomas Winkler
2008-06-16  6:08                             ` Maxim Levitsky
2008-06-16  6:46                               ` Maxim Levitsky
2008-06-16  7:11                                 ` Maxim Levitsky
2008-06-16 14:35                               ` Dan Williams
2008-06-16 21:41                                 ` Tomas Winkler
2008-06-18  8:28                             ` drago01
2008-06-24 19:47                               ` John W. Linville
2008-06-24 20:32                                 ` Maxim Levitsky
2008-06-25  5:43                                 ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213322439.7814.770.camel@debian.sh.intel.com \
    --to=yi.zhu@intel.com \
    --cc=dcbw@redhat.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.