All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Tidy up 'make' output
Date: Tue, 17 Jun 2008 16:25:44 -0400	[thread overview]
Message-ID: <1213734344.32234.2.camel@dv> (raw)
In-Reply-To: <20080617130708.493de46a@gibibit.com>

On Tue, 2008-06-17 at 13:07 -0700, Colin D Bennett wrote:
> On Tue, 17 Jun 2008 15:57:47 -0400
> Pavel Roskin <proski@gnu.org> wrote:
> 
> > On Tue, 2008-06-17 at 10:44 -0700, Colin D Bennett wrote:
> > > When thousands of long, wrapped lines full of command line options
> > > and file names are scrolling by on your terminal, it is very hard
> > > to pick out the irregularities in the build process, such as error
> > > and warnings.
> > 
> > I like the idea, but the massive use of "override" doesn't looks
> > right. I'd rather see variables with different names used throughout
> > the makefiles.  Linux makefiles don't use "override" at all.
> > "override" should be the last resort if everything else fails.
> 
> Ok.  Well, are implicit make rules ever used in the makefiles?

I don't think so.  "make -r" is working fine for me.

>   If so,
> we would have to make them explicit in order to use a different
> compiler variable.  I tried to touch the least number of things
> possible with my patch.

That's a good idea, but doing things right should take priority.  If you
want, you can split your work along different lines - silence CC first,
then LD and so on.

> If you wish, I can take a crack at eliminating the use of 'override'
> and using a different set of make variables for the instrumented calls
> to commands.

That would be great.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-06-17 20:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 17:44 [PATCH] Tidy up 'make' output Colin D Bennett
2008-06-17 19:57 ` Pavel Roskin
2008-06-17 20:07   ` Colin D Bennett
2008-06-17 20:25     ` Pavel Roskin [this message]
2008-06-17 20:37 ` Robert Millan
2008-06-17 20:53   ` Pavel Roskin
2008-06-17 22:22   ` Stefan Reinauer
2008-06-18 17:43     ` Robert Millan
2008-06-17 22:31   ` Colin D Bennett
2008-06-18 17:46     ` Robert Millan
2008-06-18 18:02       ` Pavel Roskin
2008-06-18 22:21         ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213734344.32234.2.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.