All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Tidy up 'make' output
Date: Tue, 17 Jun 2008 22:37:10 +0200	[thread overview]
Message-ID: <20080617203710.GA31785@thorin> (raw)
In-Reply-To: <20080617104448.2b43f109@gibibit.com>

On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote:
> with output that, in my opinion, makes it easier to see warnings and
> errors:
> 
>   COMPILE         ../util/getroot.c
>   COMPILE         ../kern/device.c
>   ../kern/device.c: In function 'grub_device_iterate':
>   ../kern/device.c:84: warning: generating trampoline in object
>   (requires executable stack)
>   ../kern/device.c:84: warning: generating trampoline in object
>   (requires executable stack)
>   COMPILE         ../kern/disk.c 
>   COMPILE         ../kern/err.c
>   COMPILE         ../kern/misc.c

I don't like the idea of hiding information this way.  If the goal is to
catch warnings, I think -Werror can do a much better job (and catching
errors shouldn't be a problem unless you're using make -j or -k).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)



  parent reply	other threads:[~2008-06-17 20:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 17:44 [PATCH] Tidy up 'make' output Colin D Bennett
2008-06-17 19:57 ` Pavel Roskin
2008-06-17 20:07   ` Colin D Bennett
2008-06-17 20:25     ` Pavel Roskin
2008-06-17 20:37 ` Robert Millan [this message]
2008-06-17 20:53   ` Pavel Roskin
2008-06-17 22:22   ` Stefan Reinauer
2008-06-18 17:43     ` Robert Millan
2008-06-17 22:31   ` Colin D Bennett
2008-06-18 17:46     ` Robert Millan
2008-06-18 18:02       ` Pavel Roskin
2008-06-18 22:21         ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080617203710.GA31785@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.