Re: [PATCH] [RESEND] fix HID quirks for aluminium apple wireless keyboards

["Phil Endecott" <phil_tuhck_endecott@chezphil.org>]

Paul Collins wrote:
> "Phil Endecott" <phil_tuhck_endecott@chezphil.org> writes:
>
>> Why do you set HID_QUIRK_APPLE_NUMLOCK_EMULATION ?  I don't know what
>> that quirk really does, but since these keyboards have neither a
>> numeric keypad nor a numlock key I can't see any benefit.
>
> From a quick skim of the code (drivers/hid/hid-input.c) it looks like
> it's supposed to allow a laptop-style numeric keymap mapping to be
> enabled with F6, but I can't make it do anything here.  Perhaps it is
> best removed after the hid-bus merge, otherwise there'll be different
> quirks in different places for the same devices.

The general policy seems to be to make these keyboards behave the same 
on Linux as they do with Macs.  My guess is that they don't have any 
numeric keypad emulation feature on Macs - can anyone confirm?  In that 
case it shouldn't be enabled.  Personally, I wouldn't like to 
accidentally press F6 (e.g. pressing all the fn keys in turn looking 
for the "right one"), and then discover that half of the 
letter/punctuation keys were broken, and have no idea how to "fix" it.


Phil.