From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac80211: get rid of function pointers in TX path
Date: Thu, 19 Jun 2008 16:32:01 -0700 [thread overview]
Message-ID: <1213918321.6591.4.camel@brick> (raw)
In-Reply-To: <20080619232434.586735000@sipsolutions.net>
On Fri, 2008-06-20 at 01:22 +0200, Johannes Berg wrote:
> +#define CALL_TXH(txh) \
> + res = txh(tx); \
> + if (res != TX_CONTINUE) \
> + goto txh_done;
> +
> + CALL_TXH(ieee80211_tx_h_check_assoc)
> + CALL_TXH(ieee80211_tx_h_sequence);
> + CALL_TXH(ieee80211_tx_h_ps_buf);
> + CALL_TXH(ieee80211_tx_h_select_key);
> + CALL_TXH(ieee80211_tx_h_michael_mic_add);
> + CALL_TXH(ieee80211_tx_h_rate_ctrl);
> + CALL_TXH(ieee80211_tx_h_misc);
> + CALL_TXH(ieee80211_tx_h_fragment);
> + /* handlers after fragment must be aware of tx info fragmentation! */
> + CALL_TXH(ieee80211_tx_h_encrypt);
> + CALL_TXH(ieee80211_tx_h_calculate_duration);
> + CALL_TXH(ieee80211_tx_h_stats);
> +#undef CALL_TXH
Unnecessary ; after each CALL_TXH()...except the first.
Same thing for 3/3 on the receive side.
Other than that (small) bit, looks ok at first glance.
Harvey
next prev parent reply other threads:[~2008-06-19 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 23:22 [PATCH 0/3] improve code in TX/RX paths Johannes Berg
2008-06-19 23:22 ` [PATCH 1/3] mac80211: add single function calling tx handlers Johannes Berg
2008-06-19 23:22 ` [PATCH 2/3] mac80211: get rid of function pointers in TX path Johannes Berg
2008-06-19 23:32 ` Harvey Harrison [this message]
2008-06-19 23:35 ` Johannes Berg
2008-06-19 23:22 ` [PATCH 3/3] mac80211: get rid of function pointers in RX path Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213918321.6591.4.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.