Re: [PATCH 2/3] mac80211: get rid of function pointers in TX path

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Thu, 2008-06-19 at 16:32 -0700, Harvey Harrison wrote:
> On Fri, 2008-06-20 at 01:22 +0200, Johannes Berg wrote:
> > +#define CALL_TXH(txh)		\
> > +	res = txh(tx);		\
> > +	if (res != TX_CONTINUE)	\
> > +		goto txh_done;
> > +
> > +	CALL_TXH(ieee80211_tx_h_check_assoc)
> > +	CALL_TXH(ieee80211_tx_h_sequence);
> > +	CALL_TXH(ieee80211_tx_h_ps_buf);
> > +	CALL_TXH(ieee80211_tx_h_select_key);
> > +	CALL_TXH(ieee80211_tx_h_michael_mic_add);
> > +	CALL_TXH(ieee80211_tx_h_rate_ctrl);
> > +	CALL_TXH(ieee80211_tx_h_misc);
> > +	CALL_TXH(ieee80211_tx_h_fragment);
> > +	/* handlers after fragment must be aware of tx info fragmentation! */
> > +	CALL_TXH(ieee80211_tx_h_encrypt);
> > +	CALL_TXH(ieee80211_tx_h_calculate_duration);
> > +	CALL_TXH(ieee80211_tx_h_stats);
> > +#undef CALL_TXH
> 
> Unnecessary ; after each CALL_TXH()...except the first.
> 
> Same thing for 3/3 on the receive side.

Yeah, that's fair, it's not a function call in any way so it need not
look like one either. I'll resend tomorrow (just in case somebody else
finds something else).

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]