All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Cohen <eli@dev.mellanox.co.il>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Roland Dreier <rdreier@cisco.com>,
	Vladimir Sokolovsky <vlad@mellanox.co.il>,
	Or Gerlitz <or.gerlitz@gmail.com>,
	OpenFabrics General <general@lists.openfabrics.org>,
	Jan-Bernd Themann <THEMANN@de.ibm.com>
Subject: [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able
Date: Tue, 24 Jun 2008 17:39:46 +0300	[thread overview]
Message-ID: <1214318386.23583.37.camel@mtls03> (raw)

>From 59c28d377ddfb7c13e2e1ecbf184211704d0e61d Mon Sep 17 00:00:00 2001
From: Eli Cohen <eli@mellanox.co.il>
Date: Tue, 24 Jun 2008 17:17:14 +0300
Subject: [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able

When an SKB cannot be chained to a session, the current code attempts
to "restore" its ip_summed field from lro_mgr->ip_summed. However,
lro_mgr->ip_summed does not hold the original value; in fact, we'd
better not touch skb->ip_summed since it is not modified by the code
in the path leading to a failure to chain it.

Issue raised by Or Gerlitz <ogerlitz@voltaire.com>

Signed-off-by: Eli Cohen <eli@mellanox.co.il>
---
 net/ipv4/inet_lro.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c
index 4a4d49f..cfd034a 100644
--- a/net/ipv4/inet_lro.c
+++ b/net/ipv4/inet_lro.c
@@ -383,8 +383,7 @@ static int __lro_proc_skb(struct net_lro_mgr *lro_mgr, struct sk_buff *skb,
 out2: /* send aggregated SKBs to stack */
 	lro_flush(lro_mgr, lro_desc);
 
-out:  /* Original SKB has to be posted to stack */
-	skb->ip_summed = lro_mgr->ip_summed;
+out:
 	return 1;
 }
 
-- 
1.5.6




             reply	other threads:[~2008-06-24 14:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 14:39 Eli Cohen [this message]
2008-06-25  9:26 ` [ofa-general] [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able Or Gerlitz
2008-06-25 11:28   ` Jan-Bernd Themann
2008-06-25 11:47     ` Or Gerlitz
2008-06-25 12:10       ` Jan-Bernd Themann
2008-06-25 12:15       ` Jan-Bernd Themann
2008-06-25 12:30       ` Eli Cohen
2008-06-25 13:01         ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214318386.23583.37.camel@mtls03 \
    --to=eli@dev.mellanox.co.il \
    --cc=THEMANN@de.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=or.gerlitz@gmail.com \
    --cc=rdreier@cisco.com \
    --cc=vlad@mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.