From: Peter Zijlstra <peterz@infradead.org>
To: MinChan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
akpm@linux-foundation.org,
Takenori Nagano <t-nagano@ah.jp.nec.com>
Subject: Re: [RFC][PATCH] prevent incorrect oom under split_lru
Date: Wed, 25 Jun 2008 14:11:25 +0200 [thread overview]
Message-ID: <1214395885.15232.17.camel@twins> (raw)
In-Reply-To: <28c262360806242356n3f7e02abwfee1f6acf0fd2c61@mail.gmail.com>
On Wed, 2008-06-25 at 15:56 +0900, MinChan Kim wrote:
> On Wed, Jun 25, 2008 at 3:08 PM, KOSAKI Motohiro
> <kosaki.motohiro@jp.fujitsu.com> wrote:
> > Hi Kim-san,
> >
> >> >> So, if priority==0, We should try to reclaim all page for prevent OOM.
> >> >
> >> > You are absolutely right. Good catch.
> >>
> >> I have a concern about application latency.
> >> If lru list have many pages, it take a very long time to scan pages.
> >> More system have many ram, More many time to scan pages.
> >
> > No problem.
> >
> > priority==0 indicate emergency.
> > it doesn't happend on typical workload.
> >
>
> I see :)
>
> But if such emergency happen in embedded system, application can't be
> executed for some time.
> I am not sure how long time it take.
> But In some application, schedule period is very important than memory
> reclaim latency.
>
> Now, In your patch, when such emergency happen, it continue to reclaim
> page until it will scan entire page of lru list.
> It
IMHO embedded real-time apps shoud mlockall() and not do anything that
can result in memory allocations in their fast (deterministic) paths.
The much more important case is desktop usage - that is where we run non
real-time code, but do expect 'low' latency due to user-interaction.
>From hitting swap on my 512M laptop (rather frequent occurance) I know
we can do better here,..
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: MinChan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
akpm@linux-foundation.org,
Takenori Nagano <t-nagano@ah.jp.nec.com>
Subject: Re: [RFC][PATCH] prevent incorrect oom under split_lru
Date: Wed, 25 Jun 2008 14:11:25 +0200 [thread overview]
Message-ID: <1214395885.15232.17.camel@twins> (raw)
In-Reply-To: <28c262360806242356n3f7e02abwfee1f6acf0fd2c61@mail.gmail.com>
On Wed, 2008-06-25 at 15:56 +0900, MinChan Kim wrote:
> On Wed, Jun 25, 2008 at 3:08 PM, KOSAKI Motohiro
> <kosaki.motohiro@jp.fujitsu.com> wrote:
> > Hi Kim-san,
> >
> >> >> So, if priority==0, We should try to reclaim all page for prevent OOM.
> >> >
> >> > You are absolutely right. Good catch.
> >>
> >> I have a concern about application latency.
> >> If lru list have many pages, it take a very long time to scan pages.
> >> More system have many ram, More many time to scan pages.
> >
> > No problem.
> >
> > priority==0 indicate emergency.
> > it doesn't happend on typical workload.
> >
>
> I see :)
>
> But if such emergency happen in embedded system, application can't be
> executed for some time.
> I am not sure how long time it take.
> But In some application, schedule period is very important than memory
> reclaim latency.
>
> Now, In your patch, when such emergency happen, it continue to reclaim
> page until it will scan entire page of lru list.
> It
IMHO embedded real-time apps shoud mlockall() and not do anything that
can result in memory allocations in their fast (deterministic) paths.
The much more important case is desktop usage - that is where we run non
real-time code, but do expect 'low' latency due to user-interaction.
>From hitting swap on my 512M laptop (rather frequent occurance) I know
we can do better here,..
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-25 12:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 8:31 [RFC][PATCH] prevent incorrect oom under split_lru KOSAKI Motohiro
2008-06-24 8:31 ` KOSAKI Motohiro
2008-06-24 13:28 ` Rik van Riel
2008-06-24 13:28 ` Rik van Riel
2008-06-25 5:59 ` MinChan Kim
2008-06-25 5:59 ` MinChan Kim
2008-06-25 6:08 ` KOSAKI Motohiro
2008-06-25 6:08 ` KOSAKI Motohiro
2008-06-25 6:56 ` MinChan Kim
2008-06-25 6:56 ` MinChan Kim
2008-06-25 6:58 ` MinChan Kim
2008-06-25 6:58 ` MinChan Kim
2008-06-25 7:29 ` KOSAKI Motohiro
2008-06-25 7:29 ` KOSAKI Motohiro
2008-06-25 7:37 ` MinChan Kim
2008-06-25 7:37 ` MinChan Kim
2008-06-25 12:11 ` Peter Zijlstra [this message]
2008-06-25 12:11 ` Peter Zijlstra
2008-06-25 13:05 ` MinChan Kim
2008-06-25 13:05 ` MinChan Kim
2008-06-26 1:49 ` Takenori Nagano
2008-06-26 1:49 ` Takenori Nagano
2008-06-26 4:37 ` MinChan Kim
2008-06-26 4:37 ` MinChan Kim
2008-06-26 5:24 ` Takenori Nagano
2008-06-26 5:24 ` Takenori Nagano
2008-06-26 6:37 ` MinChan Kim
2008-06-26 6:37 ` MinChan Kim
2008-06-26 8:05 ` Takenori Nagano
2008-06-26 8:05 ` Takenori Nagano
2008-06-26 0:36 ` KOSAKI Motohiro
2008-06-26 0:36 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214395885.15232.17.camel@twins \
--to=peterz@infradead.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=t-nagano@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.