From: Hollis Blanchard <hollisb@us.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
Jerone Young <jyoung5@us.ibm.com>
Subject: Re: [PATCH] [v2] Remove use of bit fields in kvm trace structure
Date: Wed, 25 Jun 2008 15:55:53 +0000 [thread overview]
Message-ID: <1214409353.1746.5.camel@localhost.localdomain> (raw)
In-Reply-To: <5ba8c03afeab340508e0.1214333686@thinkpadL>
On Tue, 2008-06-24 at 13:54 -0500, Jerone Young wrote:
> 2 files changed, 30 insertions(+), 11 deletions(-)
> include/linux/kvm.h | 17 ++++++++++++++---
> virt/kvm/kvm_trace.c | 24 ++++++++++++++++--------
>
>
> *Updates:
> Create global definitions for setting trace records as opposed to
> explicitly setting them inside of a function.
>
> This patch fixes kvmtrace use on big endian systems. When using bit
> fields the compiler will lay data out in the wrong order expected when
> laid down into a file. This fixes it by using one variable instead of
> using bit fields.
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
Avi, if this is OK now, please also apply Jerone's earlier patches:
[PATCH 2 of 3] Move KVM TRACE DEFINITIONS to common header
[PATCH 3 of 3] Add new KVM TRACE events
(and add my Acked-by to those as well).
--
Hollis Blanchard
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb@us.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
Jerone Young <jyoung5@us.ibm.com>
Subject: Re: [PATCH] [v2] Remove use of bit fields in kvm trace structure
Date: Wed, 25 Jun 2008 10:55:53 -0500 [thread overview]
Message-ID: <1214409353.1746.5.camel@localhost.localdomain> (raw)
In-Reply-To: <5ba8c03afeab340508e0.1214333686@thinkpadL>
On Tue, 2008-06-24 at 13:54 -0500, Jerone Young wrote:
> 2 files changed, 30 insertions(+), 11 deletions(-)
> include/linux/kvm.h | 17 ++++++++++++++---
> virt/kvm/kvm_trace.c | 24 ++++++++++++++++--------
>
>
> *Updates:
> Create global definitions for setting trace records as opposed to
> explicitly setting them inside of a function.
>
> This patch fixes kvmtrace use on big endian systems. When using bit
> fields the compiler will lay data out in the wrong order expected when
> laid down into a file. This fixes it by using one variable instead of
> using bit fields.
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
Avi, if this is OK now, please also apply Jerone's earlier patches:
[PATCH 2 of 3] Move KVM TRACE DEFINITIONS to common header
[PATCH 3 of 3] Add new KVM TRACE events
(and add my Acked-by to those as well).
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-06-25 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 18:54 [PATCH] [v2] Remove use of bit fields in kvm trace structure Jerone Young
2008-06-24 18:54 ` Jerone Young
2008-06-25 15:55 ` Hollis Blanchard [this message]
2008-06-25 15:55 ` Hollis Blanchard
2008-07-05 9:37 ` Avi Kivity
2008-07-05 9:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214409353.1746.5.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=avi@qumranet.com \
--cc=jyoung5@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.