From: "Javier Martín" <lordhabbit@gmail.com>
To: grub-devel@gnu.org
Subject: [PATCH] Small fix in grub-setup
Date: Mon, 30 Jun 2008 03:58:34 +0200 [thread overview]
Message-ID: <1214791114.9353.4.camel@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
Here goes a small fix to a grub-setup error that has driven /me crazy
for the last 4 hours: in the recent split between core_path and
core_path_dev, one occurrence of the former that should have been turned
into the latter was not, thus making grub-setup spit lots of nonsensical
(to me) "error: file not found" messages. I spent a big deal of time
trying to debug the wrong piece of code, since I stubbornly thought that
the error was in the "read-and-check" loop, while it really was later in
the file... Sigh
The fix is so simple that I post it directly here. If a ChangeLog entry
is necessary, I'd propose "complete core_path variable split" or
something along that lines.
Index: util/i386/pc/grub-setup.c
===================================================================
RCS file: /sources/grub/grub2/util/i386/pc/grub-setup.c,v
retrieving revision 1.39
diff -u -r1.39 grub-setup.c
--- util/i386/pc/grub-setup.c 26 Jun 2008 15:29:32 -0000 1.39
+++ util/i386/pc/grub-setup.c 30 Jun 2008 01:53:00 -0000
@@ -452,7 +452,7 @@
}
/* Now read the core image to determine where the sectors are. */
- file = grub_file_open (core_path);
+ file = grub_file_open (core_path_dev);
if (! file)
grub_util_error ("%s", grub_errmsg);
[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
next reply other threads:[~2008-06-30 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 1:58 Javier Martín [this message]
2008-06-30 21:12 ` [PATCH] Small fix in grub-setup Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214791114.9353.4.camel@localhost \
--to=lordhabbit@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.