All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Small fix in grub-setup
Date: Mon, 30 Jun 2008 17:12:23 -0400	[thread overview]
Message-ID: <1214860343.19717.3.camel@dv> (raw)
In-Reply-To: <1214791114.9353.4.camel@localhost>

On Mon, 2008-06-30 at 03:58 +0200, Javier Martín wrote:
> Here goes a small fix to a grub-setup error that has driven /me crazy
> for the last 4 hours: in the recent split between core_path and
> core_path_dev, one occurrence of the former that should have been turned
> into the latter was not, thus making grub-setup spit lots of nonsensical
> (to me) "error: file not found" messages. I spent a big deal of time
> trying to debug the wrong piece of code, since I stubbornly thought that
> the error was in the "read-and-check" loop, while it really was later in
> the file... Sigh

I understand you were trying to install GRUB to a non-default root.  I'm
sorry for not testing that.

> The fix is so simple that I post it directly here. If a ChangeLog entry
> is necessary, I'd propose "complete core_path variable split" or
> something along that lines.

Actually, it's a real bug, so ChangeLog shouldn't be worded like it's
another cosmetic change like the original patch was meant to be.

I've applied your patch.  Thank you!

-- 
Regards,
Pavel Roskin



      reply	other threads:[~2008-06-30 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30  1:58 [PATCH] Small fix in grub-setup Javier Martín
2008-06-30 21:12 ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214860343.19717.3.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.