From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Eliminating grub_size_t
Date: Thu, 03 Jul 2008 14:29:55 -0400 [thread overview]
Message-ID: <1215109795.4585.17.camel@dv> (raw)
In-Reply-To: <87bq1e7so2.fsf@xs4all.nl>
On Thu, 2008-07-03 at 20:02 +0200, Marco Gerards wrote:
> > I know what it is. I believe int should be as good as size_t for most
> > purposes is we are not working with very large structures or read
> > gigabytes of data from files at once.
>
> Perhaps, but it doesn't hurt either. I think it is a good thing to
> have a type such that it is clear what kind of variable is used.
I mean, we can have the type, but make it 32-bit on all systems.
Anyway, the warnings have been fixed. In some cases, grub_size_t was
used for offsets, which is wrong because we want to support large files
on 32-bit systems.
I think I'll try to make grub_size_t 32-bit everywhere and see if it's
going to make any difference or help discover some issues.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-07-03 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 2:14 Eliminating grub_size_t Pavel Roskin
2008-07-02 2:33 ` Javier Martín
2008-07-02 4:20 ` Pavel Roskin
2008-07-02 10:26 ` Isaac Dupree
2008-07-02 13:23 ` Pavel Roskin
2008-07-02 17:46 ` Vesa Jääskeläinen
2008-07-02 17:51 ` Pavel Roskin
2008-07-03 18:02 ` Marco Gerards
2008-07-03 18:29 ` Pavel Roskin [this message]
2008-07-03 18:42 ` Vesa Jääskeläinen
2008-07-03 18:52 ` Pavel Roskin
2008-07-03 19:07 ` Vesa Jääskeläinen
2008-07-03 19:16 ` Pavel Roskin
2008-07-03 18:56 ` Marco Gerards
2008-07-03 19:05 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215109795.4585.17.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.