From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de, jgarzik@pobox.com
Subject: Re: [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.
Date: Tue, 08 Jul 2008 10:46:06 +1000 [thread overview]
Message-ID: <1215477966.8970.181.camel@pasglop> (raw)
In-Reply-To: <C497F939.104DB%gerickson@nuovations.com>
On Mon, 2008-07-07 at 16:47 -0700, Grant Erickson wrote:
>
> Would you prefer?
>
> +#define RGMII_FER_MII(idx) RGMII_FER_GMII(idx)
>
> Having the "extra" mnemonic makes the code end up looking less like a typo
> and more like a conscious decision: "Yes, we know MII and GMII are the same
> setting, but we're being explicit about it."
Yeah, that looks better. Either that or a comment.
Cheers,
Ben.
next prev parent reply other threads:[~2008-07-08 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 23:31 [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge Grant Erickson
2008-07-07 23:40 ` Benjamin Herrenschmidt
2008-07-07 23:47 ` Grant Erickson
2008-07-08 0:46 ` Benjamin Herrenschmidt [this message]
2008-07-08 15:03 ` [PATCH v2] " Grant Erickson
2008-07-08 15:35 ` Stefan Roese
2008-07-09 3:23 ` Benjamin Herrenschmidt
2008-07-11 5:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215477966.8970.181.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=gerickson@nuovations.com \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.