All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, sr@denx.de,
	Grant Erickson <gerickson@nuovations.com>
Subject: Re: [PATCH v2] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.
Date: Fri, 11 Jul 2008 01:19:43 -0400	[thread overview]
Message-ID: <4876ED6F.2030107@pobox.com> (raw)
In-Reply-To: <1215573802.8970.302.camel@pasglop>

Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-08 at 08:03 -0700, Grant Erickson wrote:
>> This patch adds support to the RGMII handler in the EMAC driver for
>> the MII PHY mode such that device tree entries of the form `phy-mode = "mii";'
>> are recognized and handled appropriately.
>>
>> While logically, in software, "gmii" and "mii" modes are the same,
>> they are wired differently, so it makes sense to allow DTS authors to
>> specify each explicitly.
>>
>> Signed-off-by: Grant Erickson <gerickson@nuovations.com>
> 
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

ACK


> Jeff, I'd like to apply that (and other EMAC patches for 2.6.27, do you
> have anything else pending ?) via my tree provided you give me your ack.
> The reason is that the multicast fix one is going that way as it touches
> other arch files, and subsequent ones are now likely to conflict.
> 
> Let me know if that's ok with you in which case I'll stick your ack in
> there.

Ok w/ me!

      reply	other threads:[~2008-07-11  5:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 23:31 [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge Grant Erickson
2008-07-07 23:40 ` Benjamin Herrenschmidt
2008-07-07 23:47   ` Grant Erickson
2008-07-08  0:46     ` Benjamin Herrenschmidt
2008-07-08 15:03     ` [PATCH v2] " Grant Erickson
2008-07-08 15:35       ` Stefan Roese
2008-07-09  3:23       ` Benjamin Herrenschmidt
2008-07-11  5:19         ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4876ED6F.2030107@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=benh@kernel.crashing.org \
    --cc=gerickson@nuovations.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.