From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Daisuke Nishimura
<nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
Cc: YAMAMOTO Takashi
<yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org>,
Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
KOSAKI Motohiro
<kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Hugh Dickins <hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org>,
Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
Balbir Singh
<balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH -mm 1/5] swapcgroup (v3): add cgroup files
Date: Thu, 10 Jul 2008 13:35:36 -0700 [thread overview]
Message-ID: <1215722136.9398.59.camel@nimitz> (raw)
In-Reply-To: <20080704151747.470d62a3.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
On Fri, 2008-07-04 at 15:17 +0900, Daisuke Nishimura wrote:
> +config CGROUP_SWAP_RES_CTLR
> + bool "Swap Resource Controller for Control Groups"
> + depends on CGROUP_MEM_RES_CTLR && SWAP
> + help
> + Provides a swap resource controller that manages and limits swap usage.
> + Implemented as a add-on to Memory Resource Controller.
Could you make this just plain depend on 'CGROUP_MEM_RES_CTLR && SWAP'
and not make it configurable? I don't think the resource usage really
justifies yet another .config knob to tune and break. :)
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Linux Containers <containers@lists.osdl.org>,
Linux MM <linux-mm@kvack.org>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Hugh Dickins <hugh@veritas.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH -mm 1/5] swapcgroup (v3): add cgroup files
Date: Thu, 10 Jul 2008 13:35:36 -0700 [thread overview]
Message-ID: <1215722136.9398.59.camel@nimitz> (raw)
In-Reply-To: <20080704151747.470d62a3.nishimura@mxp.nes.nec.co.jp>
On Fri, 2008-07-04 at 15:17 +0900, Daisuke Nishimura wrote:
> +config CGROUP_SWAP_RES_CTLR
> + bool "Swap Resource Controller for Control Groups"
> + depends on CGROUP_MEM_RES_CTLR && SWAP
> + help
> + Provides a swap resource controller that manages and limits swap usage.
> + Implemented as a add-on to Memory Resource Controller.
Could you make this just plain depend on 'CGROUP_MEM_RES_CTLR && SWAP'
and not make it configurable? I don't think the resource usage really
justifies yet another .config knob to tune and break. :)
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-10 20:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 6:15 [PATCH -mm 0/5] swapcgroup (v3) Daisuke Nishimura
2008-07-04 6:15 ` Daisuke Nishimura
[not found] ` <20080704151536.e5384231.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-04 6:17 ` [PATCH -mm 1/5] swapcgroup (v3): add cgroup files Daisuke Nishimura
2008-07-04 6:17 ` Daisuke Nishimura
[not found] ` <20080704151747.470d62a3.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-10 20:35 ` Dave Hansen [this message]
2008-07-10 20:35 ` Dave Hansen
2008-07-11 11:02 ` Daisuke Nishimura
2008-07-11 11:02 ` Daisuke Nishimura
2008-07-04 6:18 ` [PATCH -mm 2/5] swapcgroup (v3): add a member to swap_info_struct Daisuke Nishimura
2008-07-04 6:18 ` Daisuke Nishimura
2008-07-04 6:20 ` [PATCH -mm 3/5] swapcgroup (v3): implement charge and uncharge Daisuke Nishimura
2008-07-04 6:20 ` Daisuke Nishimura
2008-07-04 6:22 ` [PATCH -mm 4/5] swapcgroup (v3): modify vm_swap_full() Daisuke Nishimura
2008-07-04 6:22 ` Daisuke Nishimura
[not found] ` <20080704152244.7fc2ccd1.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-04 9:58 ` KAMEZAWA Hiroyuki
2008-07-04 9:58 ` KAMEZAWA Hiroyuki
[not found] ` <20080704185845.0baaca76.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-07-04 10:40 ` Daisuke Nishimura
2008-07-04 10:40 ` Daisuke Nishimura
2008-07-04 6:24 ` [PATCH -mm 5/5] swapcgroup (v3): implement force_empty Daisuke Nishimura
2008-07-04 6:24 ` Daisuke Nishimura
[not found] ` <20080704152423.f65932b3.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-04 6:54 ` YAMAMOTO Takashi
2008-07-04 6:54 ` YAMAMOTO Takashi
[not found] ` <20080704065431.A8BDC5A19-Pcsii4f/SVk@public.gmane.org>
2008-07-04 7:26 ` Daisuke Nishimura
2008-07-04 7:26 ` Daisuke Nishimura
[not found] ` <20080704162629.b06b6810.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-04 7:48 ` YAMAMOTO Takashi
2008-07-04 7:48 ` YAMAMOTO Takashi
[not found] ` <20080704074828.330DC5A19-Pcsii4f/SVk@public.gmane.org>
2008-07-04 7:56 ` Daisuke Nishimura
2008-07-04 7:56 ` Daisuke Nishimura
2008-07-04 10:16 ` KAMEZAWA Hiroyuki
2008-07-04 10:16 ` KAMEZAWA Hiroyuki
[not found] ` <20080704191638.b63892f5.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-07-04 12:33 ` Daisuke Nishimura
2008-07-04 12:33 ` Daisuke Nishimura
[not found] ` <20080704213301.7d476941.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-07-05 4:29 ` KAMEZAWA Hiroyuki
2008-07-05 4:29 ` KAMEZAWA Hiroyuki
[not found] ` <20080705132944.7cf07bd8.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-07-07 6:23 ` Daisuke Nishimura
2008-07-07 6:23 ` Daisuke Nishimura
2008-07-04 9:40 ` [PATCH -mm 0/5] swapcgroup (v3) KAMEZAWA Hiroyuki
2008-07-04 9:40 ` KAMEZAWA Hiroyuki
[not found] ` <20080704184033.7cac4b69.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-07-04 10:58 ` Daisuke Nishimura
2008-07-04 10:58 ` Daisuke Nishimura
2008-07-05 6:52 ` Balbir Singh
2008-07-05 6:52 ` Balbir Singh
[not found] ` <486F1A29.4020407-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-07-07 6:48 ` Daisuke Nishimura
2008-07-07 6:48 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215722136.9398.59.camel@nimitz \
--to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org \
--cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org \
--cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.