From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: a bug in read
Date: Fri, 11 Jul 2008 14:23:17 -0400 [thread overview]
Message-ID: <1215800597.29731.11.camel@dv> (raw)
In-Reply-To: <bda1cfca0807091056g149fab1etacec69851424759f@mail.gmail.com>
On Wed, 2008-07-09 at 19:56 +0200, Javier Martín wrote:
> Couldn't this have been worked around changing while to do-while and
> refactoring the loop instead of creating a new variable, whose
> handling takes space? I'm not sure it can be done because I'm on
> vacation and reading mail through dialup access, but it might be worth
> a try.
A new variable was useful anyway to strip the final newline, but
changing the loop logic made the code more readable. It's a standard
case where the exit condition occurs in the middle of the block, not in
the beginning or in the end.
The patch has been applied.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-07-11 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 22:18 a bug in read Yoshinori K. Okuji
2008-07-09 6:14 ` Pavel Roskin
2008-07-09 17:05 ` Vesa Jääskeläinen
2008-07-09 17:56 ` Javier Martín
2008-07-11 18:23 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215800597.29731.11.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.