* sfx.c driver build failure
@ 2008-07-25 6:15 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 10+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-25 6:15 UTC (permalink / raw)
To: Michael Brown; +Cc: linuxppc-dev list, Jeff Garzik, Linux Kernel list
Hi Michael !
The sfx driver (which happens to be part of some of our test configs)
fails to build in current Linus tree on powerpc with this error:
/home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
/home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ oper
and
Cheers,
Ben.
^ permalink raw reply [flat|nested] 10+ messages in thread
* sfx.c driver build failure
@ 2008-07-25 6:15 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 10+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-25 6:15 UTC (permalink / raw)
To: Michael Brown; +Cc: Linux Kernel list, linuxppc-dev list, Jeff Garzik
Hi Michael !
The sfx driver (which happens to be part of some of our test configs)
fails to build in current Linus tree on powerpc with this error:
/home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
/home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ oper
and
Cheers,
Ben.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
2008-07-25 6:15 ` Benjamin Herrenschmidt
@ 2008-07-25 7:17 ` Stephen Rothwell
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2008-07-25 7:17 UTC (permalink / raw)
To: benh
Cc: list, Michael Brown, linuxppc-dev list, Linux, Ingo Molnar,
Jeff Garzik
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> The sfx driver (which happens to be part of some of our test configs)
> fails to build in current Linus tree on powerpc with this error:
>
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
topology_core_siblings() breakage" in linux-next (from the cpus4096 tree)
comments out the offending lines ... With the comment "the topology API
is a mess right now".
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
@ 2008-07-25 7:17 ` Stephen Rothwell
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2008-07-25 7:17 UTC (permalink / raw)
To: benh
Cc: Michael Brown, linuxppc-dev list, Jeff Garzik, Linux Kernel list,
Ingo Molnar
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> The sfx driver (which happens to be part of some of our test configs)
> fails to build in current Linus tree on powerpc with this error:
>
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
topology_core_siblings() breakage" in linux-next (from the cpus4096 tree)
comments out the offending lines ... With the comment "the topology API
is a mess right now".
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
2008-07-25 7:17 ` Stephen Rothwell
@ 2008-07-25 7:32 ` Ingo Molnar
-1 siblings, 0 replies; 10+ messages in thread
From: Ingo Molnar @ 2008-07-25 7:32 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linuxppc-dev list, Jeff Garzik, Linux Kernel list, Michael Brown
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
>
> Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
> topology_core_siblings() breakage" in linux-next (from the cpus4096
> tree) comments out the offending lines ... With the comment "the
> topology API is a mess right now".
there's a patch from Mike Travis that solves it all from grounds up and
which approach has the ack of Rusty as well, but it's not fully tested
through yet - i will get to it later today.
Ingo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
@ 2008-07-25 7:32 ` Ingo Molnar
0 siblings, 0 replies; 10+ messages in thread
From: Ingo Molnar @ 2008-07-25 7:32 UTC (permalink / raw)
To: Stephen Rothwell
Cc: benh, Michael Brown, linuxppc-dev list, Jeff Garzik,
Linux Kernel list
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
>
> Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
> topology_core_siblings() breakage" in linux-next (from the cpus4096
> tree) comments out the offending lines ... With the comment "the
> topology API is a mess right now".
there's a patch from Mike Travis that solves it all from grounds up and
which approach has the ack of Rusty as well, but it's not fully tested
through yet - i will get to it later today.
Ingo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
2008-07-25 6:15 ` Benjamin Herrenschmidt
@ 2008-07-25 7:35 ` Michael Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Brown @ 2008-07-25 7:35 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list, Jeff Garzik, Linux Kernel list
[-- Attachment #1: Type: TEXT/PLAIN, Size: 674 bytes --]
On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
> The sfx driver (which happens to be part of some of our test configs)
> fails to build in current Linus tree on powerpc with this error:
>
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ:
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper
> and
I'm not the maintainer of that code; I wrote the original version, but
it's now maintained by Solarflare.
I don't see anything on that line that ought to be architecture-specific.
Could you send me the preprocessed efx.c from your powerpc build?
Michael
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
@ 2008-07-25 7:35 ` Michael Brown
0 siblings, 0 replies; 10+ messages in thread
From: Michael Brown @ 2008-07-25 7:35 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Linux Kernel list, linuxppc-dev list, Jeff Garzik
[-- Attachment #1: Type: TEXT/PLAIN, Size: 674 bytes --]
On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
> The sfx driver (which happens to be part of some of our test configs)
> fails to build in current Linus tree on powerpc with this error:
>
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ:
> /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper
> and
I'm not the maintainer of that code; I wrote the original version, but
it's now maintained by Solarflare.
I don't see anything on that line that ought to be architecture-specific.
Could you send me the preprocessed efx.c from your powerpc build?
Michael
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
2008-07-25 7:35 ` Michael Brown
@ 2008-07-25 7:50 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 10+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-25 7:50 UTC (permalink / raw)
To: Michael Brown; +Cc: linuxppc-dev list, Jeff Garzik, Linux Kernel list
On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote:
> On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper
> > and
>
> I'm not the maintainer of that code; I wrote the original version, but
> it's now maintained by Solarflare.
>
> I don't see anything on that line that ought to be architecture-specific.
> Could you send me the preprocessed efx.c from your powerpc build?
Apparently, it's a know generic breakage of the topology stuff,
it's beeing sorted out.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: sfx.c driver build failure
@ 2008-07-25 7:50 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 10+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-25 7:50 UTC (permalink / raw)
To: Michael Brown; +Cc: Linux Kernel list, linuxppc-dev list, Jeff Garzik
On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote:
> On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper
> > and
>
> I'm not the maintainer of that code; I wrote the original version, but
> it's now maintained by Solarflare.
>
> I don't see anything on that line that ought to be architecture-specific.
> Could you send me the preprocessed efx.c from your powerpc build?
Apparently, it's a know generic breakage of the topology stuff,
it's beeing sorted out.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-07-25 8:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 6:15 sfx.c driver build failure Benjamin Herrenschmidt
2008-07-25 6:15 ` Benjamin Herrenschmidt
2008-07-25 7:17 ` Stephen Rothwell
2008-07-25 7:17 ` Stephen Rothwell
2008-07-25 7:32 ` Ingo Molnar
2008-07-25 7:32 ` Ingo Molnar
2008-07-25 7:35 ` Michael Brown
2008-07-25 7:35 ` Michael Brown
2008-07-25 7:50 ` Benjamin Herrenschmidt
2008-07-25 7:50 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.