From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Abort grub-install if prefix cannot be determined
Date: Fri, 25 Jul 2008 17:49:03 -0400 [thread overview]
Message-ID: <1217022543.3957.6.camel@dv> (raw)
In-Reply-To: <20080725203751.GC18149@thorin>
On Fri, 2008-07-25 at 22:37 +0200, Robert Millan wrote:
> On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote:
> > grub-install does not check error return from
> > make_system_path_relative_to_its_root() fails.
> >
> > BTW: Unlike the other scripts, grub-install does not 'set -e'. Is this
> > intentional or historic ?-)
>
> I think it's historic. Wouldn't mind moving it to 'set -e' (although one
> would have to check which grub-probe calls are allowed to fail). What
> do others think?
I agree with you. It's better to add explicit "|| :" to a few commands
that can fail than to allow every command to fail.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-07-25 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 5:39 [PATCH] Abort grub-install if prefix cannot be determined Christian Franke
2008-07-24 19:04 ` Christian Franke
2008-07-25 20:37 ` Robert Millan
2008-07-25 21:49 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217022543.3957.6.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.