From: Matt Helsley <matthltc@us.ibm.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
Cedric Le Goater <clg@fr.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Michael Opdenacker <michael@free-electrons.com>,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH 2/6] Container Freezer: Make refrigerator always available
Date: Fri, 01 Aug 2008 19:30:26 -0700 [thread overview]
Message-ID: <1217644226.25300.296.camel@localhost.localdomain> (raw)
In-Reply-To: <200808020053.18638.rjw@sisk.pl>
On Sat, 2008-08-02 at 00:53 +-0200, Rafael J. Wysocki wrote:
+AD4 On Friday, 1 of August 2008, Matt Helsley wrote:
+AD4 +AD4
+AD4 +AD4 On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote:
+AD4 +AD4 +AD4 Hi,
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 Le Thu, 31 Jul 2008 22:07:01 -0700,
+AD4 +AD4 +AD4 Matt Helsley +ADw-matthltc+AEA-us.ibm.com+AD4 a +AOk-crit :
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 +AD4 --- a/kernel/Makefile
+AD4 +AD4 +AD4 +AD4 +-+-+- b/kernel/Makefile
+AD4 +AD4 +AD4 +AD4 +AEAAQA -5,7 +-5,7 +AEAAQA
+AD4 +AD4 +AD4 +AD4 obj-y +AD0 sched.o fork.o exec+AF8-domain.o panic.o printk.o +AFw
+AD4 +AD4 +AD4 +AD4 cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw
+AD4 +AD4 +AD4 +AD4 sysctl.o capability.o ptrace.o timer.o user.o +AFw
+AD4 +AD4 +AD4 +AD4 - signal.o sys.o kmod.o workqueue.o pid.o +AFw
+AD4 +AD4 +AD4 +AD4 +- signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 I have the impression that the code in kernel/power/process.c was
+AD4 +AD4 +AD4 compiled only if CONFIG+AF8-PM+AF8-SLEEP was set. Now that the code has been
+AD4 +AD4 +AD4 moved to kernel/freezer.c, it is unconditionnaly compiled in every
+AD4 +AD4 +AD4 kernel. Is that correct ?
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 If so, is it possible to put this new feature under some
+AD4 +AD4 +AD4 CONFIG+AF8-SOMETHING option, for people who care about the kernel size ?
+AD4 +AD4
+AD4 +AD4 How about making it depend on a combination of CONFIG variables?
+AD4 +AD4 Here's an RFC PATCH. Completely untested.
+AD4 +AD4
+AD4 +AD4 Signed-off-by: Matt Helsley +ADw-matthltc+AEA-us.ibm.com+AD4
+AD4
+AD4 Can you please also make the contents of include/linux/freezer.h depend on
+AD4 CONFIG+AF8-FREEZER instead of CONFIG+AF8-PM+AF8-SLEEP?
Done.
+AD4 Also, I'm not really sure if kernel/power/Kconfig is the right place to define
+AD4 CONFIG+AF8-FREEZER.
+AD4
+AD4 Perhaps we should even move freezer.c from kernel/power to kernel
+AD4 and define CONFIG+AF8-FREEZER in Kconfig in there. Andrew, what do you think?
I'll check this weekend for replies and repost the RFC PATCH on Monday
if I don't hear anything. In the meantime I'll be doing some config
build testing with the above changes to make sure it's correct.
Cheers,
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: Matt Helsley <matthltc@us.ibm.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
Cedric Le Goater <clg@fr.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Michael Opdenacker <michael@free-electrons.com>,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH 2/6] Container Freezer: Make refrigerator always available
Date: Fri, 01 Aug 2008 19:30:26 -0700 [thread overview]
Message-ID: <1217644226.25300.296.camel@localhost.localdomain> (raw)
In-Reply-To: <200808020053.18638.rjw@sisk.pl>
On Sat, 2008-08-02 at 00:53 +0200, Rafael J. Wysocki wrote:
> On Friday, 1 of August 2008, Matt Helsley wrote:
> >
> > On Fri, 2008-08-01 at 16:27 +0200, Thomas Petazzoni wrote:
> > > Hi,
> > >
> > > Le Thu, 31 Jul 2008 22:07:01 -0700,
> > > Matt Helsley <matthltc@us.ibm.com> a écrit :
> > >
> > > > --- a/kernel/Makefile
> > > > +++ b/kernel/Makefile
> > > > @@ -5,7 +5,7 @@
> > > > obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
> > > > cpu.o exit.o itimer.o time.o softirq.o resource.o \
> > > > sysctl.o capability.o ptrace.o timer.o user.o \
> > > > - signal.o sys.o kmod.o workqueue.o pid.o \
> > > > + signal.o sys.o kmod.o workqueue.o pid.o freezer.o \
> > >
> > > I have the impression that the code in kernel/power/process.c was
> > > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been
> > > moved to kernel/freezer.c, it is unconditionnaly compiled in every
> > > kernel. Is that correct ?
> > >
> > > If so, is it possible to put this new feature under some
> > > CONFIG_SOMETHING option, for people who care about the kernel size ?
> >
> > How about making it depend on a combination of CONFIG variables?
> > Here's an RFC PATCH. Completely untested.
> >
> > Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
>
> Can you please also make the contents of include/linux/freezer.h depend on
> CONFIG_FREEZER instead of CONFIG_PM_SLEEP?
Done.
> Also, I'm not really sure if kernel/power/Kconfig is the right place to define
> CONFIG_FREEZER.
>
> Perhaps we should even move freezer.c from kernel/power to kernel
> and define CONFIG_FREEZER in Kconfig in there. Andrew, what do you think?
I'll check this weekend for replies and repost the RFC PATCH on Monday
if I don't hear anything. In the meantime I'll be doing some config
build testing with the above changes to make sure it's correct.
Cheers,
-Matt
next prev parent reply other threads:[~2008-08-02 2:30 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 5:06 [PATCH 0/6] Container Freezer: Reuse Suspend Freezer Matt Helsley
2008-08-01 5:06 ` Matt Helsley
2008-08-01 5:07 ` [PATCH 1/6] Container Freezer: Add TIF_FREEZE flag to all architectures Matt Helsley
2008-08-01 10:32 ` Nigel Cunningham
2008-08-01 12:32 ` Cedric Le Goater
2008-08-01 12:32 ` Cedric Le Goater
2008-08-01 22:05 ` Matt Helsley
[not found] ` <4893025D.9090801-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-08-01 22:05 ` Matt Helsley
2008-08-01 22:05 ` Matt Helsley
[not found] ` <1217628325.25300.270.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-01 22:54 ` Rafael J. Wysocki
2008-08-02 1:13 ` Nigel Cunningham
2008-08-01 22:54 ` Rafael J. Wysocki
2008-08-01 22:54 ` Rafael J. Wysocki
2008-08-02 1:13 ` Nigel Cunningham
2008-08-02 1:13 ` Nigel Cunningham
2008-08-01 12:32 ` Cedric Le Goater
2008-08-01 10:32 ` Nigel Cunningham
[not found] ` <20080801050700.261080433-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-01 10:32 ` Nigel Cunningham
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` [PATCH 2/6] Container Freezer: Make refrigerator always available Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 10:33 ` Nigel Cunningham
2008-08-01 10:33 ` Nigel Cunningham
2008-08-01 14:27 ` Thomas Petazzoni
2008-08-01 14:27 ` Thomas Petazzoni
2008-08-01 19:08 ` Matt Helsley
2008-08-01 19:08 ` Matt Helsley
2008-08-01 22:53 ` Rafael J. Wysocki
2008-08-01 22:53 ` Rafael J. Wysocki
2008-08-01 22:53 ` Rafael J. Wysocki
2008-08-01 23:24 ` Matt Helsley
2008-08-01 23:24 ` Matt Helsley
2008-08-02 14:34 ` Rafael J. Wysocki
2008-08-02 14:34 ` Rafael J. Wysocki
2008-08-02 14:34 ` Rafael J. Wysocki
[not found] ` <1217633074.25300.281.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-02 14:34 ` Rafael J. Wysocki
2008-08-01 23:24 ` Matt Helsley
[not found] ` <200808020053.18638.rjw-KKrjLPT3xs0@public.gmane.org>
2008-08-01 23:24 ` Matt Helsley
2008-08-02 2:30 ` Matt Helsley
2008-08-02 2:30 ` Matt Helsley [this message]
2008-08-02 2:30 ` Matt Helsley
2008-08-02 2:30 ` Matt Helsley
[not found] ` <1217617689.25300.213.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-01 22:53 ` Rafael J. Wysocki
2008-08-02 10:39 ` Thomas Petazzoni
2008-08-02 10:39 ` Thomas Petazzoni
2008-08-02 10:39 ` Thomas Petazzoni
2008-08-02 10:39 ` Thomas Petazzoni
2008-08-01 19:08 ` Matt Helsley
2008-08-01 19:08 ` Matt Helsley
[not found] ` <20080801050700.528446138-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-01 10:33 ` Nigel Cunningham
2008-08-01 14:27 ` Thomas Petazzoni
2008-08-01 14:27 ` Thomas Petazzoni
2008-08-01 5:07 ` [PATCH 3/6] Container Freezer: Implement freezer cgroup subsystem Matt Helsley
2008-08-01 5:07 ` Matt Helsley
[not found] ` <20080801050700.797996261-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-01 22:58 ` Rafael J. Wysocki
2008-08-01 22:58 ` Rafael J. Wysocki
2008-08-01 22:58 ` Rafael J. Wysocki
2008-08-02 0:11 ` Matt Helsley
2008-08-02 0:11 ` Matt Helsley
[not found] ` <1217635891.25300.292.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-02 7:38 ` Cedric Le Goater
2008-08-02 7:38 ` Cedric Le Goater
2008-08-02 7:38 ` Cedric Le Goater
2008-08-02 14:37 ` Rafael J. Wysocki
2008-08-02 14:37 ` Rafael J. Wysocki
[not found] ` <48940F0F.4050604-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-08-02 14:37 ` Rafael J. Wysocki
[not found] ` <200808020058.37407.rjw-KKrjLPT3xs0@public.gmane.org>
2008-08-02 0:11 ` Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` [PATCH 4/6] Container Freezer: Skip frozen cgroups during power management resume Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 10:24 ` Nigel Cunningham
2008-08-01 10:24 ` Nigel Cunningham
[not found] ` <20080801050701.070484831-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-01 10:24 ` Nigel Cunningham
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` [PATCH 5/6] Container Freezer: Prevent frozen tasks or cgroups from changing Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` [PATCH 6/6] Container Freezer: Use cgroup write_string method Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:07 ` Matt Helsley
2008-08-01 5:16 ` [PATCH 0/6] Container Freezer: Reuse Suspend Freezer Matt Helsley
2008-08-01 13:04 ` Rafael J. Wysocki
2008-08-01 13:04 ` Rafael J. Wysocki
[not found] ` <1217567816.25300.197.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-01 13:04 ` Rafael J. Wysocki
[not found] ` <20080801050659.924495279-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-01 5:16 ` Matt Helsley
2008-08-01 5:16 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217644226.25300.296.camel@localhost.localdomain \
--to=matthltc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=michael@free-electrons.com \
--cc=rjw@sisk.pl \
--cc=serue@us.ibm.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.