From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastien Dugue <sebastien.dugue@bull.net>
Cc: tinytim@us.ibm.com, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
jean-pierre.dion@bull.net, linuxppc-dev@ozlabs.org,
paulus@samba.org, gilles.carry@ext.bull.net, tglx@linutronix.de
Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier
Date: Tue, 05 Aug 2008 11:05:03 +1000 [thread overview]
Message-ID: <1217898303.24157.122.camel@pasglop> (raw)
In-Reply-To: <1217898226.24157.120.camel@pasglop>
> - Remove the populating of the tree from the revmap function as
> you already do
> - Move it to irq_create_mapping() for the normal case
> - For pre-existing interrupt, have the generic code that initializes
> the radix tree walk through all interrupts and setup the revmap for
> them. If that needs locking vs. concurrent irq_create_mapping, it's
> easy to use one of the available spinlocks for that.
And in fact, you may even be able to avoid GFP_ATOMIC completely here
and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik,
provided that you avoid the spinlocking.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastien Dugue <sebastien.dugue@bull.net>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, paulus@samba.org,
michael@ellerman.id.au, jean-pierre.dion@bull.net,
gilles.carry@ext.bull.net, tinytim@us.ibm.com,
tglx@linutronix.de, rostedt@goodmis.org
Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier
Date: Tue, 05 Aug 2008 11:05:03 +1000 [thread overview]
Message-ID: <1217898303.24157.122.camel@pasglop> (raw)
In-Reply-To: <1217898226.24157.120.camel@pasglop>
> - Remove the populating of the tree from the revmap function as
> you already do
> - Move it to irq_create_mapping() for the normal case
> - For pre-existing interrupt, have the generic code that initializes
> the radix tree walk through all interrupts and setup the revmap for
> them. If that needs locking vs. concurrent irq_create_mapping, it's
> easy to use one of the available spinlocks for that.
And in fact, you may even be able to avoid GFP_ATOMIC completely here
and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik,
provided that you avoid the spinlocking.
Ben.
next prev parent reply other threads:[~2008-08-05 1:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 11:08 [PATCH 0/3 V2] powerpc - Make the irq reverse mapping tree lockless Sebastien Dugue
2008-08-04 11:08 ` Sebastien Dugue
2008-08-04 11:08 ` [PATCH 1/3] powerpc - Initialize the irq radix tree earlier Sebastien Dugue
2008-08-04 11:08 ` Sebastien Dugue
2008-08-05 1:03 ` Benjamin Herrenschmidt
2008-08-05 1:03 ` Benjamin Herrenschmidt
2008-08-05 1:05 ` Benjamin Herrenschmidt [this message]
2008-08-05 1:05 ` Benjamin Herrenschmidt
2008-08-05 8:27 ` Sebastien Dugue
2008-08-05 8:27 ` Sebastien Dugue
2008-08-05 8:26 ` Sebastien Dugue
2008-08-04 11:08 ` [PATCH 2/3] powerpc - Separate the irq radix tree insertion and lookup Sebastien Dugue
2008-08-04 11:08 ` Sebastien Dugue
2008-08-04 11:08 ` [PATCH 3/3] powerpc - Make the irq reverse mapping radix tree lockless Sebastien Dugue
2008-08-04 11:08 ` Sebastien Dugue
2008-08-04 16:31 ` Daniel Walker
2008-08-04 16:31 ` Daniel Walker
2008-08-05 8:28 ` Sebastien Dugue
2008-08-05 8:28 ` Sebastien Dugue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217898303.24157.122.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=gilles.carry@ext.bull.net \
--cc=jean-pierre.dion@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sebastien.dugue@bull.net \
--cc=tglx@linutronix.de \
--cc=tinytim@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.