From: jamal <hadi@cyberus.ca>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: iproute2/m_ipt fix, opts was not set properly
Date: Wed, 06 Aug 2008 06:42:30 -0400 [thread overview]
Message-ID: <1218019350.4755.30.camel@localhost> (raw)
In-Reply-To: <200808061306.39846.denys@visp.net.lb>
On Wed, 2008-06-08 at 13:06 +0300, Denys Fedoryshchenko wrote:
> Make attention - before static void free_opts(struct option *opts) was
> shadowing global variable with same name *opts, after this patch - it will
> not shadow anymore.
Sorry Denys, unless my memory has lost the C scoping rules, i dont think
the shadowing you describe above is accurate. Let me take a closer look.
[BTW, this code was all copied from iptables - so if this bug exists
here, it likely still exists in iptables. The xtables changes will make
this code a lot more maintainable].
cheers,
jamal
next prev parent reply other threads:[~2008-08-06 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 19:24 iproute2/m_ipt fix, opts was not set properly Denys Fedoryshchenko
2008-08-06 9:52 ` jamal
2008-08-06 10:06 ` Denys Fedoryshchenko
2008-08-06 10:42 ` jamal [this message]
2008-08-06 10:52 ` jamal
2008-08-06 11:02 ` Denys Fedoryshchenko
2008-08-06 11:18 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218019350.4755.30.camel@localhost \
--to=hadi@cyberus.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.