From: jamal <hadi@cyberus.ca>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: iproute2/m_ipt fix, opts was not set properly
Date: Wed, 06 Aug 2008 07:18:16 -0400 [thread overview]
Message-ID: <1218021496.4755.54.camel@localhost> (raw)
In-Reply-To: <200808061402.01021.denys@visp.net.lb>
On Wed, 2008-06-08 at 14:02 +0300, Denys Fedoryshchenko wrote:
> Does it work on my test batch?
I havent tested with your scenario as i am staring at your script
and trying to construct a simple case. It was just eyeballing.
The original code was not resetting the contents "pointed to"
by opts. So on return from free_opts, nothing has changed really.
> Your way looks much more clean :-)
> (I cannot test it properly, since i have modified iproute2 now)
It should work but i will test it. The simple test case i can think of
is to have two ipt invocations with different parameters (eg mark and
set tos).
If you test it, please resubmit with new approach. I will let you know
my results (as i have a few vacation hours to kill this morning).
cheers,
jamal
prev parent reply other threads:[~2008-08-06 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 19:24 iproute2/m_ipt fix, opts was not set properly Denys Fedoryshchenko
2008-08-06 9:52 ` jamal
2008-08-06 10:06 ` Denys Fedoryshchenko
2008-08-06 10:42 ` jamal
2008-08-06 10:52 ` jamal
2008-08-06 11:02 ` Denys Fedoryshchenko
2008-08-06 11:18 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218021496.4755.54.camel@localhost \
--to=hadi@cyberus.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.