From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [PATCH] Warning fixes
Date: Wed, 06 Aug 2008 09:39:02 -0400 [thread overview]
Message-ID: <1218029942.27785.3.camel@ct> (raw)
Hello!
I've fixed the trivial stuff, but this may require comments. I'll be
mostly offline for the next 3 weeks, so if it's OK, please apply it for
me.
ChangeLog:
* disk/ata.c (grub_ata_pciinit): Mark pciid unused.
* commands/i386/pc/pxecmd.c (grub_cmd_pxe): Mark argc and args
unused.
* include/grub/i386/pc/pxe.h (grub_pxenv_tftp_open): Use char
instead of grub_uint8_t for strings.
(grub_pxenv_tftp_get_fsize): Likewise.
Index: disk/ata.c
===================================================================
--- disk/ata.c (revision 1784)
+++ disk/ata.c (working copy)
@@ -429,7 +429,8 @@
}
static int
-grub_ata_pciinit (int bus, int device, int func, grub_pci_id_t pciid)
+grub_ata_pciinit (int bus, int device, int func,
+ grub_pci_id_t pciid __attribute__ ((unused)))
{
static int compat_use[2] = { 0 };
grub_pci_address_t addr;
Index: include/grub/i386/pc/pxe.h
===================================================================
--- include/grub/i386/pc/pxe.h (revision 1784)
+++ include/grub/i386/pc/pxe.h (working copy)
@@ -236,7 +236,7 @@
grub_uint16_t status;
grub_uint32_t server_ip;
grub_uint32_t gateway_ip;
- grub_uint8_t filename[128];
+ char filename[128];
grub_uint16_t tftp_port;
grub_uint16_t packet_size;
} __attribute__ ((packed));
@@ -259,7 +259,7 @@
grub_uint16_t status;
grub_uint32_t server_ip;
grub_uint32_t gateway_ip;
- grub_uint8_t filename[128];
+ char filename[128];
grub_uint32_t file_size;
} __attribute__ ((packed));
Index: commands/i386/pc/pxecmd.c
===================================================================
--- commands/i386/pc/pxecmd.c (revision 1784)
+++ commands/i386/pc/pxecmd.c (working copy)
@@ -46,7 +46,9 @@
}
static grub_err_t
-grub_cmd_pxe (struct grub_arg_list *state, int argc, char **args)
+grub_cmd_pxe (struct grub_arg_list *state,
+ int argc __attribute__ ((unused)),
+ char **args __attribute__ ((unused)))
{
if (! grub_pxe_pxenv)
return grub_error (GRUB_ERR_FILE_NOT_FOUND, "no pxe environment");
--
Regards,
Pavel Roskin
next reply other threads:[~2008-08-06 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 13:39 Pavel Roskin [this message]
2008-08-06 13:58 ` [PATCH] Warning fixes Colin D Bennett
2008-08-06 14:32 ` Pavel Roskin
2008-08-06 15:08 ` Colin D Bennett
2008-08-13 10:18 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218029942.27785.3.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.