All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Pavel Machek <pavel@suse.cz>
Cc: nigel@nigel.suspend2.net,
	Kexec Mailing List <kexec@lists.infradead.org>,
	linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	mingo@elte.hu, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 1/6] kexec jump: clean up #ifdef and comments
Date: Thu, 07 Aug 2008 17:29:04 +0800	[thread overview]
Message-ID: <1218101344.5164.38.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <20080807092058.GB372@atrey.karlin.mff.cuni.cz>

On Thu, 2008-08-07 at 11:20 +0200, Pavel Machek wrote:
> Hi!
> 
> > CONFIG_KEXEC_JUMP to make code looks cleaner.
> > 
> > Fix no longer correct comments of kernel_kexec().
> > 
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> > 
> > ---
> >  kernel/kexec.c |   11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> > --- a/kernel/kexec.c
> > +++ b/kernel/kexec.c
> > @@ -1427,8 +1427,6 @@ static int __init crash_save_vmcoreinfo_
> >  module_init(crash_save_vmcoreinfo_init)
> >  
> >  /**
> > - *	kernel_kexec - reboot the system
> > - *
> >   *	Move into place and start executing a preloaded standalone
> >   *	executable.  If nothing was preloaded return an error.
> >   */
> 
> If it is not kerneldoc, it should not be /** .

OK. I will fix it.

Best Regards,
Huang Ying



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Huang Ying <ying.huang@intel.com>
To: Pavel Machek <pavel@suse.cz>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	nigel@nigel.suspend2.net, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	mingo@elte.hu, Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH 1/6] kexec jump: clean up #ifdef and comments
Date: Thu, 07 Aug 2008 17:29:04 +0800	[thread overview]
Message-ID: <1218101344.5164.38.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <20080807092058.GB372@atrey.karlin.mff.cuni.cz>

On Thu, 2008-08-07 at 11:20 +0200, Pavel Machek wrote:
> Hi!
> 
> > CONFIG_KEXEC_JUMP to make code looks cleaner.
> > 
> > Fix no longer correct comments of kernel_kexec().
> > 
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> > 
> > ---
> >  kernel/kexec.c |   11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> > --- a/kernel/kexec.c
> > +++ b/kernel/kexec.c
> > @@ -1427,8 +1427,6 @@ static int __init crash_save_vmcoreinfo_
> >  module_init(crash_save_vmcoreinfo_init)
> >  
> >  /**
> > - *	kernel_kexec - reboot the system
> > - *
> >   *	Move into place and start executing a preloaded standalone
> >   *	executable.  If nothing was preloaded return an error.
> >   */
> 
> If it is not kerneldoc, it should not be /** .

OK. I will fix it.

Best Regards,
Huang Ying



  reply	other threads:[~2008-08-07  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07  9:05 [PATCH 1/6] kexec jump: clean up #ifdef and comments Huang Ying
2008-08-07  9:05 ` Huang Ying
2008-08-07  9:20 ` Pavel Machek
2008-08-07  9:20   ` Pavel Machek
2008-08-07  9:29   ` Huang Ying [this message]
2008-08-07  9:29     ` Huang Ying
2008-08-07 13:04 ` Vivek Goyal
2008-08-07 13:04   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218101344.5164.38.camel@caritas-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nigel@nigel.suspend2.net \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.