From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julien Brunel <brunel@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/s390: Use an IS_ERR test rather than a NULL
Date: Thu, 07 Aug 2008 13:49:12 +0000 [thread overview]
Message-ID: <1218116952.1033.37.camel@localhost> (raw)
In-Reply-To: <200808071542.22880.brunel@diku.dk>
On Thu, 2008-08-07 at 15:42 +0200, Julien Brunel wrote:
> In case of error, functions dasd_kmalloc_request and idal_buffer_alloc
> return an ERR pointer, but never return the NULL pointer. So after a
> call to one of these functions, a NULL test should be replaced by an
> IS_ERR test.
Good findings, many thanks! I'll add it to git390 for the next please
pull.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Julien Brunel <brunel@diku.dk>
Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/s390: Use an IS_ERR test rather than a NULL test
Date: Thu, 07 Aug 2008 15:49:12 +0200 [thread overview]
Message-ID: <1218116952.1033.37.camel@localhost> (raw)
In-Reply-To: <200808071542.22880.brunel@diku.dk>
On Thu, 2008-08-07 at 15:42 +0200, Julien Brunel wrote:
> In case of error, functions dasd_kmalloc_request and idal_buffer_alloc
> return an ERR pointer, but never return the NULL pointer. So after a
> call to one of these functions, a NULL test should be replaced by an
> IS_ERR test.
Good findings, many thanks! I'll add it to git390 for the next please
pull.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-08-07 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 13:42 [PATCH] drivers/s390: Use an IS_ERR test rather than a NULL test Julien Brunel
2008-08-07 13:42 ` Julien Brunel
2008-08-07 13:49 ` Martin Schwidefsky [this message]
2008-08-07 13:49 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218116952.1033.37.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=brunel@diku.dk \
--cc=heiko.carstens@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.