* Re: [PATCH]ip: Allow for easier debug of buggy devices that dont send their names
2008-08-08 14:00 [PATCH]ip: Allow for easier debug of buggy devices that dont send their names jamal
@ 2008-08-08 14:06 ` jamal
0 siblings, 0 replies; 2+ messages in thread
From: jamal @ 2008-08-08 14:06 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
patch attached this time..
On Fri, 2008-08-08 at 10:01 -0400, jamal wrote:
> wireless drivers using wext is a prime example if you need a test case.
>
> cheers,
> jamal
[-- Attachment #2: iprl1 --]
[-- Type: text/plain, Size: 1229 bytes --]
ip: Allow for easier debug of buggy devices that dont send their names
With the old message couldnt tell which device had the bug.
This patch provides at least an ifindex to narrow it down.
Theres also no point in bailing out because of one bug; we
allow it to go on so we could dump as much info as we can
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
---
commit 741059fd8ae6c07794d56c56395354f95543f648
tree 0a0e8e4508a2d08c4bd450fcb1c74142fbd64837
parent 488f1c77fec1b283ef5237943d397786f90d2fe5
author Jamal Hadi Salim <hadi@cyberus.ca> Fri, 08 Aug 2008 09:57:49 -0400
committer Jamal Hadi Salim <hadi@cyberus.ca> Fri, 08 Aug 2008 09:57:49 -0400
ip/ipaddress.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 373312f..a5af36d 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -210,8 +210,7 @@ int print_linkinfo(const struct sockaddr_nl *who,
parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), len);
if (tb[IFLA_IFNAME] == NULL) {
- fprintf(stderr, "BUG: nil ifname\n");
- return -1;
+ fprintf(stderr, "BUG: device with ifindex %d has nil ifname\n", ifi->ifi_index);
}
if (filter.label &&
(!filter.family || filter.family == AF_PACKET) &&
^ permalink raw reply related [flat|nested] 2+ messages in thread