All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, cl@linux-foundation.org
Subject: Re: [RFC/PATCH] SLUB: dynamic per-cache MIN_PARTIAL
Date: Tue, 12 Aug 2008 15:33:53 +0300	[thread overview]
Message-ID: <1218544433.7813.301.camel@penberg-laptop> (raw)
In-Reply-To: <20080812122751.GY8618@parisc-linux.org>

Hi Matthew,

On Tue, Aug 05, 2008 at 12:39:36AM +0300, Pekka J Enberg wrote:
> > This patch changes the static MIN_PARTIAL to a dynamic per-cache ->min_partial
> > value that is calculated from object size. The bigger the object size, the more
> > pages we keep on the partial list.
> > 
> > I tested SLAB, SLUB, and SLUB with this patch on Jens Axboe's 'netio' example
> > script of the fio benchmarking tool. The script stresses the networking
> > subsystem which should also give a fairly good beating of kmalloc() et al.

On Tue, 2008-08-12 at 06:27 -0600, Matthew Wilcox wrote:
> We tested this patch and it was performance-neutral on TPC-C.  I was
> hoping it would give a nice improvement ... so I'm disappointed.  But at
> least there's no regression!

OK, so your regression is something else then. Well, thanks for testing!


WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, cl@linux-foundation.org
Subject: Re: [RFC/PATCH] SLUB: dynamic per-cache MIN_PARTIAL
Date: Tue, 12 Aug 2008 15:33:53 +0300	[thread overview]
Message-ID: <1218544433.7813.301.camel@penberg-laptop> (raw)
In-Reply-To: <20080812122751.GY8618@parisc-linux.org>

Hi Matthew,

On Tue, Aug 05, 2008 at 12:39:36AM +0300, Pekka J Enberg wrote:
> > This patch changes the static MIN_PARTIAL to a dynamic per-cache ->min_partial
> > value that is calculated from object size. The bigger the object size, the more
> > pages we keep on the partial list.
> > 
> > I tested SLAB, SLUB, and SLUB with this patch on Jens Axboe's 'netio' example
> > script of the fio benchmarking tool. The script stresses the networking
> > subsystem which should also give a fairly good beating of kmalloc() et al.

i>>?On Tue, 2008-08-12 at 06:27 -0600, Matthew Wilcox wrote:
> We tested this patch and it was performance-neutral on TPC-C.  I was
> hoping it would give a nice improvement ... so I'm disappointed.  But at
> least there's no regression!

OK, so your regression is something else then. Well, thanks for testing!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-08-12 12:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04 21:39 [RFC/PATCH] SLUB: dynamic per-cache MIN_PARTIAL Pekka J Enberg
2008-08-04 21:39 ` Pekka J Enberg, Pekka Enberg
2008-08-04 21:43 ` Christoph Lameter
2008-08-04 21:43   ` Christoph Lameter
2008-08-12 12:27 ` Matthew Wilcox
2008-08-12 12:27   ` Matthew Wilcox
2008-08-12 12:33   ` Pekka Enberg [this message]
2008-08-12 12:33     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218544433.7813.301.camel@penberg-laptop \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.