From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] change grub_print_error to use stderr for the utils
Date: Tue, 12 Aug 2008 17:35:03 +0200 [thread overview]
Message-ID: <1218555303.1604.8.camel@fz.local> (raw)
In-Reply-To: <1218555015.1604.6.camel@fz.local>
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke:
> Here's now the patch Robert requested.
> grub_print_error shouldn't use stdout for the utils.
>
Bah and I attached the broken one not the working one.
So please use that one.
[-- Attachment #2: kern_err.diff --]
[-- Type: text/x-patch, Size: 572 bytes --]
Index: kern/err.c
===================================================================
--- kern/err.c (revision 1800)
+++ kern/err.c (working copy)
@@ -21,6 +21,9 @@
#include <grub/misc.h>
#include <stdarg.h>
+#ifdef GRUB_UTIL
+#include <stdio.h>
+#endif
#define GRUB_MAX_ERRMSG 256
#define GRUB_ERROR_STACK_SIZE 10
@@ -121,7 +124,11 @@
do
{
if (grub_errno != GRUB_ERR_NONE)
+#ifdef GRUB_UTIL
+ fprintf (stderr, "error: %s\n", grub_errmsg);
+#else
grub_printf ("error: %s\n", grub_errmsg);
+#endif
}
while (grub_error_pop ());
next prev parent reply other threads:[~2008-08-12 15:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 15:30 [PATCH] change grub_print_error to use stderr for the utils Felix Zielcke
2008-08-12 15:35 ` Felix Zielcke [this message]
2008-08-12 15:36 ` Vesa Jääskeläinen
2008-08-12 15:43 ` Felix Zielcke
2008-08-12 15:41 ` Robert Millan
2008-08-12 15:52 ` Felix Zielcke
2008-08-13 9:37 ` Marco Gerards
2008-08-12 16:54 ` Felix Zielcke
2008-08-13 9:38 ` Marco Gerards
2008-08-13 17:35 ` [RFC] " Felix Zielcke
2008-08-13 18:41 ` Marco Gerards
2008-08-13 19:14 ` Felix Zielcke
2008-08-14 7:07 ` Marco Gerards
2008-08-14 7:39 ` Felix Zielcke
2008-08-14 8:03 ` Marco Gerards
2008-08-14 8:05 ` Felix Zielcke
2008-08-14 17:54 ` Robert Millan
2008-08-14 18:57 ` Felix Zielcke
2008-08-16 15:06 ` Felix Zielcke
2008-08-17 15:07 ` Robert Millan
2008-08-17 15:24 ` Felix Zielcke
2008-08-17 15:34 ` Robert Millan
2008-08-17 15:47 ` Felix Zielcke
2008-08-17 16:37 ` Robert Millan
2008-08-17 16:58 ` Felix Zielcke
2008-08-17 17:04 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218555303.1604.8.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.