From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, per.liden@ericsson.com,
jon.maloy@ericsson.com, allan.stephens@windriver.com
Subject: [PATCH] tipc: Use the appropriate swab helper rather than an internal helper
Date: Tue, 12 Aug 2008 21:05:47 -0700 [thread overview]
Message-ID: <1218600348.30194.105.camel@brick> (raw)
In-Reply-To: <20080812205422.4273d598.akpm@linux-foundation.org>
___generally means I am an internal implementation detail, don't use
me.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Sorry for breaking the build Andrew, my testing has been with all the __constant
versions in-tree removed.
net/tipc/subscr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
index 0326d30..f5da05d 100644
--- a/net/tipc/subscr.c
+++ b/net/tipc/subscr.c
@@ -85,7 +85,7 @@ static struct top_srv topsrv = { 0 };
static u32 htohl(u32 in, int swap)
{
- return swap ? (u32)___constant_swab32(in) : in;
+ return swap ? (u32)swab32(in) : in;
}
/**
--
1.6.0.rc2.233.g3cb9d
next prev parent reply other threads:[~2008-08-13 4:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 0:27 [PATCH 19/22] x86: use the new byteorder headers Harvey Harrison
2008-08-13 3:54 ` Andrew Morton
2008-08-13 4:05 ` Harvey Harrison [this message]
2008-08-13 4:20 ` [PATCH] tipc: Use the appropriate swab helper rather than an internal helper Andrew Morton
2008-08-13 4:23 ` Harvey Harrison
2008-08-13 9:32 ` David Miller
2008-08-13 5:56 ` [PATCH 19/22] x86: use the new byteorder headers Andrew Morton
2008-08-13 5:59 ` David Miller
2008-08-13 6:05 ` Andrew Morton
2008-08-13 6:02 ` Andrew Morton
2008-08-13 6:07 ` Harvey Harrison
2008-08-13 6:47 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218600348.30194.105.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=allan.stephens@windriver.com \
--cc=hpa@zytor.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.