Re: [PATCH] tipc: Use the appropriate swab helper rather than an internal helper

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 12 Aug 2008 21:05:47 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:

> ___generally means I am an internal implementation detail, don't use
> me.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Sorry for breaking the build Andrew, my testing has been with all the __constant
> versions in-tree removed.
> 
>  net/tipc/subscr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
> index 0326d30..f5da05d 100644
> --- a/net/tipc/subscr.c
> +++ b/net/tipc/subscr.c
> @@ -85,7 +85,7 @@ static struct top_srv topsrv = { 0 };
>  
>  static u32 htohl(u32 in, int swap)
>  {
> -	return swap ? (u32)___constant_swab32(in) : in;
> +	return swap ? (u32)swab32(in) : in;
>  }

yes, that's what I did too, only I dropped the
seems-to-me-to-be-unneeded (u32) cast.