From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix nEXTRST on SOQuartz
Date: Fri, 21 Apr 2023 14:38:48 +0200 [thread overview]
Message-ID: <12191318.O9o76ZdvQC@archbox> (raw)
In-Reply-To: <8914603.GXAFRqVoOG@phil>
Hello,
On Friday, 21 April 2023 13:58:58 CEST Heiko Stuebner wrote:
> Hi,
>
> Am Mittwoch, 19. April 2023, 19:17:31 CEST schrieb Nicolas Frattaroli:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi index
> > ce7165d7f1a1..f589a4fdaccb 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > @@ -65,6 +65,17 @@ led_work: led-work {
> >
> > };
> >
> > };
> >
> > + nextrst_pin: nextrst-pin-regulator {
> > + compatible = "regulator-fixed";
> > + enable-active-high;
> > + gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&nextrst_h>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-name = "nextrst";
> > + };
> > +
>
> I agree with the sentiment and of course the rationale of the change,
> but not necessarily with the implementation ;-) .
>
> Why is this done as a regulator?
>
> If you want the nextrst line to be high, you could just use a gpio-hog
> for the line instead of doing a (fake?-)regulator.
Simply put: because I didn't know gpio hogs were a thing. I'll send a V2
to correct this. Thanks for pointing it out!
>
> For example the px30-ringneck.dtsi does something similar:
>
> &gpio2 {
> /*
> * The Qseven BIOS_DISABLE signal on the PX30-µQ7 keeps the
> on-module * eMMC powered-down initially (in fact it keeps the reset signal
> * asserted). BIOS_DISABLE_OVERRIDE pin allows to re-enable eMMC after * the
> SPL has been booted from SD Card.
> */
> bios-disable-override-hog {
> gpios = <RK_PB5 GPIO_ACTIVE_LOW>;
> output-high;
> line-name = "bios_disable_override";
> gpio-hog;
> };
> ...
> };
>
>
> Thanks
> Heiko
Kind regards,
Nicolas Frattaroli
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix nEXTRST on SOQuartz
Date: Fri, 21 Apr 2023 14:38:48 +0200 [thread overview]
Message-ID: <12191318.O9o76ZdvQC@archbox> (raw)
In-Reply-To: <8914603.GXAFRqVoOG@phil>
Hello,
On Friday, 21 April 2023 13:58:58 CEST Heiko Stuebner wrote:
> Hi,
>
> Am Mittwoch, 19. April 2023, 19:17:31 CEST schrieb Nicolas Frattaroli:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi index
> > ce7165d7f1a1..f589a4fdaccb 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > @@ -65,6 +65,17 @@ led_work: led-work {
> >
> > };
> >
> > };
> >
> > + nextrst_pin: nextrst-pin-regulator {
> > + compatible = "regulator-fixed";
> > + enable-active-high;
> > + gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&nextrst_h>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-name = "nextrst";
> > + };
> > +
>
> I agree with the sentiment and of course the rationale of the change,
> but not necessarily with the implementation ;-) .
>
> Why is this done as a regulator?
>
> If you want the nextrst line to be high, you could just use a gpio-hog
> for the line instead of doing a (fake?-)regulator.
Simply put: because I didn't know gpio hogs were a thing. I'll send a V2
to correct this. Thanks for pointing it out!
>
> For example the px30-ringneck.dtsi does something similar:
>
> &gpio2 {
> /*
> * The Qseven BIOS_DISABLE signal on the PX30-µQ7 keeps the
> on-module * eMMC powered-down initially (in fact it keeps the reset signal
> * asserted). BIOS_DISABLE_OVERRIDE pin allows to re-enable eMMC after * the
> SPL has been booted from SD Card.
> */
> bios-disable-override-hog {
> gpios = <RK_PB5 GPIO_ACTIVE_LOW>;
> output-high;
> line-name = "bios_disable_override";
> gpio-hog;
> };
> ...
> };
>
>
> Thanks
> Heiko
Kind regards,
Nicolas Frattaroli
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix nEXTRST on SOQuartz
Date: Fri, 21 Apr 2023 14:38:48 +0200 [thread overview]
Message-ID: <12191318.O9o76ZdvQC@archbox> (raw)
In-Reply-To: <8914603.GXAFRqVoOG@phil>
Hello,
On Friday, 21 April 2023 13:58:58 CEST Heiko Stuebner wrote:
> Hi,
>
> Am Mittwoch, 19. April 2023, 19:17:31 CEST schrieb Nicolas Frattaroli:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi index
> > ce7165d7f1a1..f589a4fdaccb 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
> > @@ -65,6 +65,17 @@ led_work: led-work {
> >
> > };
> >
> > };
> >
> > + nextrst_pin: nextrst-pin-regulator {
> > + compatible = "regulator-fixed";
> > + enable-active-high;
> > + gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&nextrst_h>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-name = "nextrst";
> > + };
> > +
>
> I agree with the sentiment and of course the rationale of the change,
> but not necessarily with the implementation ;-) .
>
> Why is this done as a regulator?
>
> If you want the nextrst line to be high, you could just use a gpio-hog
> for the line instead of doing a (fake?-)regulator.
Simply put: because I didn't know gpio hogs were a thing. I'll send a V2
to correct this. Thanks for pointing it out!
>
> For example the px30-ringneck.dtsi does something similar:
>
> &gpio2 {
> /*
> * The Qseven BIOS_DISABLE signal on the PX30-µQ7 keeps the
> on-module * eMMC powered-down initially (in fact it keeps the reset signal
> * asserted). BIOS_DISABLE_OVERRIDE pin allows to re-enable eMMC after * the
> SPL has been booted from SD Card.
> */
> bios-disable-override-hog {
> gpios = <RK_PB5 GPIO_ACTIVE_LOW>;
> output-high;
> line-name = "bios_disable_override";
> gpio-hog;
> };
> ...
> };
>
>
> Thanks
> Heiko
Kind regards,
Nicolas Frattaroli
next prev parent reply other threads:[~2023-04-21 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 17:17 [PATCH] arm64: dts: rockchip: fix nEXTRST on SOQuartz Nicolas Frattaroli
2023-04-19 17:17 ` Nicolas Frattaroli
2023-04-19 17:17 ` Nicolas Frattaroli
2023-04-21 11:58 ` Heiko Stuebner
2023-04-21 11:58 ` Heiko Stuebner
2023-04-21 11:58 ` Heiko Stuebner
2023-04-21 12:38 ` Nicolas Frattaroli [this message]
2023-04-21 12:38 ` Nicolas Frattaroli
2023-04-21 12:38 ` Nicolas Frattaroli
2023-04-21 12:39 ` Heiko Stuebner
2023-04-21 12:39 ` Heiko Stuebner
2023-04-21 12:39 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12191318.O9o76ZdvQC@archbox \
--to=frattaroli.nicolas@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.