From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel: fix dynamic printk sparse warnings
Date: Tue, 19 Aug 2008 14:50:18 -0700 [thread overview]
Message-ID: <1219182618.17033.92.camel@brick> (raw)
ret is a common variable name and creates scads of shadowed variable
warnings. Change to using __ret inside the dynamic_debug_enabled
macro.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/linux/dynamic_printk.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/dynamic_printk.h b/include/linux/dynamic_printk.h
index c54cf84..2d528d0 100644
--- a/include/linux/dynamic_printk.h
+++ b/include/linux/dynamic_printk.h
@@ -37,12 +37,12 @@ extern int __dynamic_dbg_enabled_helper(char *modname, int type,
int value, int hash);
#define __dynamic_dbg_enabled(module, type, value, level, hash) ({ \
- int ret = 0; \
+ int __ret = 0; \
if (unlikely((dynamic_printk_enabled & (1LL << DEBUG_HASH)) && \
(dynamic_printk_enabled2 & (1LL << DEBUG_HASH2)))) \
- ret = __dynamic_dbg_enabled_helper(module, type, \
+ __ret = __dynamic_dbg_enabled_helper(module, type, \
value, hash);\
- ret; })
+ __ret; })
#define dynamic_pr_debug(fmt, ...) do { \
static char mod_name[] \
--
1.6.0.274.g8aacc
reply other threads:[~2008-08-19 21:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219182618.17033.92.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.