All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel: fix dynamic printk sparse warnings
@ 2008-08-19 21:50 Harvey Harrison
  0 siblings, 0 replies; only message in thread
From: Harvey Harrison @ 2008-08-19 21:50 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Jason Baron, LKML

ret is a common variable name and creates scads of shadowed variable
warnings.  Change to using __ret inside the dynamic_debug_enabled
macro.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 include/linux/dynamic_printk.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/dynamic_printk.h b/include/linux/dynamic_printk.h
index c54cf84..2d528d0 100644
--- a/include/linux/dynamic_printk.h
+++ b/include/linux/dynamic_printk.h
@@ -37,12 +37,12 @@ extern int __dynamic_dbg_enabled_helper(char *modname, int type,
 					int value, int hash);
 
 #define __dynamic_dbg_enabled(module, type, value, level, hash)  ({	     \
-	int ret = 0;							     \
+	int __ret = 0;							     \
 	if (unlikely((dynamic_printk_enabled & (1LL << DEBUG_HASH)) &&	     \
 			(dynamic_printk_enabled2 & (1LL << DEBUG_HASH2))))   \
-			ret = __dynamic_dbg_enabled_helper(module, type,     \
+			__ret = __dynamic_dbg_enabled_helper(module, type,   \
 								value, hash);\
-	ret; })
+	__ret; })
 
 #define dynamic_pr_debug(fmt, ...) do {					    \
 	static char mod_name[]						    \
-- 
1.6.0.274.g8aacc




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-19 21:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19 21:50 [PATCH] kernel: fix dynamic printk sparse warnings Harvey Harrison

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.