From: Artem Bityutskiy <dedekind@infradead.org>
To: Julien Brunel <brunel@diku.dk>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test
Date: Fri, 29 Aug 2008 10:35:14 +0000 [thread overview]
Message-ID: <1220006114.4036.16.camel@sauron> (raw)
In-Reply-To: <200808291108.32958.brunel@diku.dk>
On Fri, 2008-08-29 at 11:08 +0200, Julien Brunel wrote:
> In case of error, the function kthread_create returns an ERR pointer,
> but never returns a NULL pointer. So a NULL test that comes before an
> IS_ERR test should be deleted.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
Pushed to ubifs-2.6.git, thanks.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind@infradead.org>
To: Julien Brunel <brunel@diku.dk>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test
Date: Fri, 29 Aug 2008 13:35:14 +0300 [thread overview]
Message-ID: <1220006114.4036.16.camel@sauron> (raw)
In-Reply-To: <200808291108.32958.brunel@diku.dk>
On Fri, 2008-08-29 at 11:08 +0200, Julien Brunel wrote:
> In case of error, the function kthread_create returns an ERR pointer,
> but never returns a NULL pointer. So a NULL test that comes before an
> IS_ERR test should be deleted.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
Pushed to ubifs-2.6.git, thanks.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-08-29 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 9:08 [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test Julien Brunel
2008-08-29 9:08 ` Julien Brunel
2008-08-29 10:35 ` Artem Bityutskiy [this message]
2008-08-29 10:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220006114.4036.16.camel@sauron \
--to=dedekind@infradead.org \
--cc=brunel@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.