All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] new static const char[] modname
Date: Sat, 30 Aug 2008 14:36:32 +0200	[thread overview]
Message-ID: <1220099792.21696.9.camel@fz.local> (raw)
In-Reply-To: <20080830120153.GG16775@thorin>

Am Samstag, den 30.08.2008, 14:01 +0200 schrieb Robert Millan:

> I think the idea with this was to unify the strings for grub_dprintf calls;
> your patch goes a bit further and also puts other sort of strings to share
> the same variable.
> 
> I think that's a bit dangerous, since changes intended for one use of the
> variable could collaterally affect the rest in subtle ways.  And it's not
> that useful in code size anyway.

Oh right, but then modname seems to be a bit the wrong name,
if it should ony be used for grub_dprintf.
For example the i386-pc biosdisc.c uses grub_dprintf("disk") and
partmap/pc.c uses "partition"

What about moddebugname or something like that then?

-- 
Felix Zielcke




  reply	other threads:[~2008-08-30 12:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 17:09 [PATCH] new static const char[] modname Felix Zielcke
2008-08-28 18:10 ` Felix Zielcke
2008-08-28 18:31   ` Marco Gerards
2008-08-28 18:38     ` Felix Zielcke
2008-08-30 12:01 ` Robert Millan
2008-08-30 12:36   ` Felix Zielcke [this message]
2008-08-30 12:42     ` Robert Millan
2008-09-01 11:24       ` [PATCH] new static const char[] channel (was: modname) Felix Zielcke
2008-09-01 21:55         ` Robert Millan
2008-09-02 13:12         ` Felix Zielcke
2008-09-02 14:05           ` [RFC] " Felix Zielcke
2008-09-02 19:20             ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220099792.21696.9.camel@fz.local \
    --to=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.