Re: [RFC] DISTLIST and gendistlist.sh

[Felix Zielcke <fzielcke@z-51.de>]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

Am Samstag, den 30.08.2008, 22:11 -0400 schrieb Pavel Roskin:

> 
> svn ls -R | sed '/\/$/d' | sort > DISTLIST2

Thanks for the regexp.
The sort is actual not needed, `svn' does this and it places even the
files with a capital letter above everything else just like
gendistlist.sh.

> > This seems to be the best then nobody needs to remember to
> > update ./gendistlist.sh and current DISTLIST seems again already a bit
> > out of date ;)

> Thus, we don't need any lists for included or excluded files.  Things
> will change if we stop keeping dependent files in Subversion.

This was just a little hint from me that some files were recently again
added to SVN without adding them to DISTLIST by e.g. calling
gendistlist.sh
But that's the point why I do this whole thing now :)

Attached is now a patch which adds ./gendistlist.sh call to autogen.sh
and uses SVN in case it is avaible to generate it.

I think this now needs the decision of Marco and Okuji because the
DISTLIST file is actual used by them i.e. `make dist'

I think using `svn ls' is really great.
But 2 questions come now in my mind:

`make dist' already creates DISTLIST if it does not exist, so
should ./autogen.sh generate it or directly `make dist'

should autogen.sh/`make dist' use directly SVN or should it be in
gendistlist.sh?

Especially should ony SVN be used to generate it or should `make dist'
be actual supported for everyone?

For me it seems that DISTLIST thing is actually only useful for Okuji
and Marco or whoever in the future will maintain GRUB 2

-- 
Felix Zielcke

[-- Attachment #2: distlist.diff.2 --]
[-- Type: text/plain, Size: 953 bytes --]

2008-08-02  Felix Zielcke  <fzielcke@z-51.de>

	* autogen.sh: Call `gendistlist.sh'.
	* gendistlist.sh: Update to use `svn' in case it is avaible.


Index: autogen.sh
===================================================================
--- autogen.sh	(Revision 1845)
+++ autogen.sh	(Arbeitskopie)
@@ -8,5 +8,6 @@ echo timestamp > stamp-h.in
 for rmk in conf/*.rmk; do
   ruby genmk.rb < $rmk > `echo $rmk | sed 's/\.rmk$/.mk/'`
 done
+./gendistlist.sh > DISTLIST
 
 exit 0
Index: gendistlist.sh
===================================================================
--- gendistlist.sh	(Revision 1845)
+++ gendistlist.sh	(Arbeitskopie)
@@ -13,6 +13,9 @@
 
 # Generate a list of distributed files.
 
+if test -d .svn ; then
+  svn ls -R | sed '/\/$/d' 
+fi
 EXTRA_DISTFILES="AUTHORS COPYING ChangeLog DISTLIST INSTALL NEWS README \
 	THANKS TODO Makefile.in aclocal.m4 autogen.sh config.guess \
 	config.h.in config.sub configure configure.ac gencmdlist.sh \