All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] DISTLIST and gendistlist.sh
Date: Tue, 02 Sep 2008 07:30:51 -0400	[thread overview]
Message-ID: <1220355051.5555.9.camel@dv> (raw)
In-Reply-To: <1220353928.4101.26.camel@fz.local>

On Tue, 2008-09-02 at 13:12 +0200, Felix Zielcke wrote:
> Am Samstag, den 30.08.2008, 22:11 -0400 schrieb Pavel Roskin:
> 
> > 
> > svn ls -R | sed '/\/$/d' | sort > DISTLIST2
> 
> Thanks for the regexp.
> The sort is actual not needed, `svn' does this and it places even the
> files with a capital letter above everything else just like
> gendistlist.sh.

If we are going to keep DISTLIST in the repository, I would not rely on
that.  I think it would be best to set locale to C and use sort to make
sure that the entries are sorted in the same way for all users.

But if we are going to remove DISTLIST from the repository, then the
order doesn't matter, so sort won't be needed.

> > > This seems to be the best then nobody needs to remember to
> > > update ./gendistlist.sh and current DISTLIST seems again already a bit
> > > out of date ;)
> 
> > Thus, we don't need any lists for included or excluded files.  Things
> > will change if we stop keeping dependent files in Subversion.
> 
> This was just a little hint from me that some files were recently again
> added to SVN without adding them to DISTLIST by e.g. calling
> gendistlist.sh
> But that's the point why I do this whole thing now :)
> 
> Attached is now a patch which adds ./gendistlist.sh call to autogen.sh
> and uses SVN in case it is avaible to generate it.
> 
> I think this now needs the decision of Marco and Okuji because the
> DISTLIST file is actual used by them i.e. `make dist'

If I was releasing GRUB, I would avoid using DISTLIST even temporarily.
I would use a separate script for making releases that would:

1) call "svn export" to create a clean tree
2) create generated files
3) remove non-distributable files (e.g. gendistlist.sh)
4) package the tree

> I think using `svn ls' is really great.
> But 2 questions come now in my mind:
> 
> `make dist' already creates DISTLIST if it does not exist, so
> should ./autogen.sh generate it or directly `make dist'
> 
> should autogen.sh/`make dist' use directly SVN or should it be in
> gendistlist.sh?
> 
> Especially should ony SVN be used to generate it or should `make dist'
> be actual supported for everyone?

I think the best approach would be to allow everyone with a svn
directory create the release tarball.  This way, many people will be
able to test the release process.  The requirement to having Subversion
is not really a big deal, and it saves the need to keep DISTLIST in the
repository.

-- 
Regards,
Pavel Roskin



  parent reply	other threads:[~2008-09-02 11:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 11:08 [RFC] DISTLIST and gendistlist.sh Felix Zielcke
2008-08-22 12:58 ` Robert Millan
2008-08-22 13:13   ` Felix Zielcke
2008-08-29 22:54     ` Felix Zielcke
2008-08-29 23:03       ` Pavel Roskin
2008-08-30  9:28         ` Felix Zielcke
2008-08-31  2:11           ` Pavel Roskin
2008-09-02 11:12             ` Felix Zielcke
2008-09-02 11:21               ` Felix Zielcke
2008-09-02 11:33                 ` Pavel Roskin
2008-09-02 11:30               ` Pavel Roskin [this message]
2008-09-04 18:21                 ` Felix Zielcke
2008-09-08 22:02                   ` Felix Zielcke
2008-09-08 22:32                     ` Robert Millan
2008-09-09  8:09                       ` Felix Zielcke
2008-09-10 21:06                         ` Pavel Roskin
2008-09-14 17:48                           ` Felix Zielcke
2008-09-21 16:40                             ` Felix Zielcke
2008-09-24 15:37                             ` Felix Zielcke
2008-09-24 16:35                               ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220355051.5555.9.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.