All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] I suggest to add -Wall to autoconf and autoheader calls
Date: Thu, 04 Sep 2008 12:44:45 -0400	[thread overview]
Message-ID: <1220546685.16992.31.camel@dv> (raw)
In-Reply-To: <1220527014.4167.28.camel@fz.local>

On Thu, 2008-09-04 at 13:16 +0200, Felix Zielcke wrote:
> With my configure.ac autoconf[0] topic I just got the idea to add
> `-Wall' option to `autoconf' in `autogen.sh'
> 
> We're using -Wall for gcc so why not for autoconf and autoheader too?
> 
> Then once in a while someone will hopefully notice that something might
> need a change and will look into it.

Fine, but only if we decide to fix the existing warnings.  I'm not sure
it's worth the trouble.  Just because a macro is considered obsolete,
it's not necessarily broken.  End users won't run Autoconf, so they
won't have problems if a newer Autoconf removes an obsolete macro.

Compiler warnings are more likely to indicate a problem with the
compiled code than autoconf warnings.  They can also indicate problems
with different compilers, and users will use different compilers.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-09-04 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 11:16 [RFC] I suggest to add -Wall to autoconf and autoheader calls Felix Zielcke
2008-09-04 16:44 ` Pavel Roskin [this message]
2008-09-04 17:40   ` Felix Zielcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220546685.16992.31.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.