All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] I suggest to add -Wall to autoconf and autoheader calls
Date: Thu, 04 Sep 2008 19:40:10 +0200	[thread overview]
Message-ID: <1220550010.18782.24.camel@fz.local> (raw)
In-Reply-To: <1220546685.16992.31.camel@dv>

Am Donnerstag, den 04.09.2008, 12:44 -0400 schrieb Pavel Roskin:
> Fine, but only if we decide to fix the existing warnings.  I'm not sure
> it's worth the trouble.  Just because a macro is considered obsolete,
> it's not necessarily broken.  End users won't run Autoconf, so they
> won't have problems if a newer Autoconf removes an obsolete macro.

All obsolete things should be mostly fixed by running `autoupdate'
For fixing the other kind of warnings I'll need to find out more about
that autoconf stuff.

With -Wall hopefully someone notices that he just introduced a warning
with his change and trys to fix this before commiting.

> Compiler warnings are more likely to indicate a problem with the
> compiled code than autoconf warnings.  They can also indicate problems
> with different compilers, and users will use different compilers.

This would be just more consistent.
But yes for the compiler and so for the code itself this is more
important.


-- 
Felix Zielcke




      reply	other threads:[~2008-09-04 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 11:16 [RFC] I suggest to add -Wall to autoconf and autoheader calls Felix Zielcke
2008-09-04 16:44 ` Pavel Roskin
2008-09-04 17:40   ` Felix Zielcke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220550010.18782.24.camel@fz.local \
    --to=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.